Gerrit: announce deprecation of auto-download of commit-msg hook.

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld."""
 
 from distutils.version import LooseVersion
@@ skipping 584 matching lines @@
       # The only value that actually changes the behavior is
       # autoupdate = "false". Everything else means "true".
       autoupdate = RunGit(['config', 'rietveld.autoupdate'],
                           error_ok=True
                           ).strip().lower()
 
       cr_settings_file = FindCodereviewSettingsFile()
       if autoupdate != 'false' and cr_settings_file:
         LoadCodereviewSettingsFromFile(cr_settings_file)
         # set updated to True to avoid infinite calling loop
-        # through DownloadHooks
+        # through DownloadGerritHook
         self.updated = True
-        DownloadHooks(False)
+        DownloadGerritHook(False)
       self.updated = True
 
   def GetDefaultServerUrl(self, error_ok=False):
     if not self.default_server:
       self.LazyUpdateIfNeeded()
       self.default_server = gclient_utils.UpgradeToHttps(
           self._GetRietveldConfig('server', error_ok=True))
       if error_ok:
         return self.default_server
       if not self.default_server:
@@ skipping 945 matching lines @@
   with open(destination, 'w') as f:
     f.write(urllib2.urlopen(source).read())
 
 
 def hasSheBang(fname):
   """Checks fname is a #! script."""
   with open(fname) as f:
     return f.read(2).startswith('#!')
 
 
-def DownloadHooks(force):
-  """downloads hooks
+def DownloadGerritHook(force):
+  """Download and install Gerrit commit-msg hook.
 
   Args:
     force: True to update hooks. False to install hooks if not present.
   """
   if not settings.GetIsGerrit():
     return
   src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
   dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
   if not os.access(dst, os.X_OK):
     if os.path.exists(dst):
       if not force:
         return
     try:
+      print(
+          'WARNING: installing Gerrit commit-msg hook.\n'
+          '         This behavior of git cl will soon be disabled.\n'
+          '         See bug http://crbug.com/579176.')
       urlretrieve(src, dst)
       if not hasSheBang(dst):
         DieWithError('Not a script: %s\n'
                      'You need to download from\n%s\n'
                      'into .git/hooks/commit-msg and '
                      'chmod +x .git/hooks/commit-msg' % (dst, src))
       os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
     except Exception:
       if os.path.exists(dst):
         os.remove(dst)
@@ skipping 18 matching lines @@
   if options.deactivate_update:
     RunGit(['config', 'rietveld.autoupdate', 'false'])
     return
 
   if options.activate_update:
     RunGit(['config', '--unset', 'rietveld.autoupdate'])
     return
 
   if len(args) == 0:
     GetCodereviewSettingsInteractively()
-    DownloadHooks(True)
+    DownloadGerritHook(True)
     return 0
 
   url = args[0]
   if not url.endswith('codereview.settings'):
     url = os.path.join(url, 'codereview.settings')
 
   # Load code review settings and download hooks (if available).
   LoadCodereviewSettingsFromFile(urllib2.urlopen(url))
-  DownloadHooks(True)
+  DownloadGerritHook(True)
   return 0
 
 
 def CMDbaseurl(parser, args):
   """Gets or sets base-url for this branch."""
   branchref = RunGit(['symbolic-ref', 'HEAD']).strip()
   branch = ShortBranchName(branchref)
   _, args = parser.parse_args(args)
   if not args:
     print("Current base-url:")
@@ skipping 2335 matching lines @@
 if __name__ == '__main__':
   # These affect sys.stdout so do it outside of main() to simplify mocks in
   # unit testing.
   fix_encoding.fix_encoding()
   colorama.init()
   try:
     sys.exit(main(sys.argv[1:]))
   except KeyboardInterrupt:
     sys.stderr.write('interrupted\n')
     sys.exit(1)