Roll Clang 261368:262839

Roll Clang 261368:262839

BUG=589647
Committed: https://crrev.com/d2af39c0b6518f0fc3be885fbc7edabe9bfa8272
Cr-Commit-Position: refs/heads/master@{#380427}

[Nico, 2016-03-05 15:34:37]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-03-05 15:34:38]

android_clang failure is real:

FAILED: /b/build/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang -MMD -MF
obj/third_party/lzma_sdk/lzma_sdk.Lzma2Dec.o.d -DV8_DEPRECATION_WARNINGS
-DCLD_VERSION=2 -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DDISABLE_NACL
-DCHROMIUM_BUILD -DCR_CLANG_REVISION=262516-1 -DCOMPONENT_BUILD
-DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1
-DUSE_PROPRIETARY_CODECS -DENABLE_BROWSER_CDMS -DENABLE_CONFIGURATION_POLICY
-DENABLE_NOTIFICATIONS -DDCHECK_ALWAYS_ON=1 -DFIELDTRIAL_TESTING_ENABLED
-DADDRESS_SANITIZER -DMEMORY_TOOL_REPLACES_ALLOCATOR
-DMEMORY_SANITIZER_INITIAL_SIZE -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PRINTING=1
-DENABLE_BASIC_PRINTING=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1
-DENABLE_SUPERVISED_USERS=1 -DVIDEO_HOLE=1 -DV8_USE_EXTERNAL_STARTUP_DATA
-DENABLE_WEBVR -DSAFE_BROWSING_DB_REMOTE -D_7ZIP_ST -D_7Z_NO_METHODS_FILTERS
-D_LZMA_PROB32 -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -DUSE_OPENSSL_CERTS=1 -DANDROID
-D__GNU_SOURCE=1 '-DCHROME_BUILD_ID=""' -DHAVE_SYS_UIO_H
-DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -Igen
-I../../third_party/lzma_sdk -fstack-protector --param=ssp-buffer-size=4 -Werror
-fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers
-fvisibility=hidden -pipe -fPIC -Xclang -load -Xclang
/b/build/slave/android_clang_dbg_recipe/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
-Xclang -add-plugin -Xclang find-bad-constructs -Xclang
-plugin-arg-find-bad-constructs -Xclang check-templates -Xclang
-plugin-arg-find-bad-constructs -Xclang follow-macro-expansion
-fcolor-diagnostics -Wheader-hygiene -Wno-char-subscripts
-Wno-unneeded-internal-declaration -Wno-covered-switch-default
-Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register
-Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-self-assign
-Wno-unused-variable -march=armv7-a -mtune=generic-armv7-a -mfpu=neon
-mfloat-abi=softfp -mthumb -marm -fno-omit-frame-pointer -gline-tables-only
-fsanitize=address -ffunction-sections -funwind-tables -g -fstack-protector
-fno-short-enums
--sysroot=../../third_party/android_tools/ndk//platforms/android-16/arch-arm
-D__compiler_offsetof=__builtin_offsetof -Dnan=__builtin_nan -target
arm-linux-androideabi -mllvm -asan-globals=0 -Os -g -fdata-sections
-ffunction-sections -funwind-tables -g0   -c
../../third_party/lzma_sdk/Lzma2Dec.c -o
obj/third_party/lzma_sdk/lzma_sdk.Lzma2Dec.o
PromoteIntegerResult #0: t47: i8,i8 = udivrem t5, Constant:i8<9>

Do not know how to promote this operator!
UNREACHABLE executed at
/usr/local/google/work/chromium/src/third_party/llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:51!
0  clang           0x0000000001873e48
llvm::sys::PrintStackTrace(llvm::raw_ostream&) + 40
1  clang           0x00000000018722f6 llvm::sys::RunSignalHandlers() + 54
2  clang           0x000000000187455e
3  libpthread.so.0 0x00007f1e762cdcb0
4  libc.so.6       0x00007f1e7550a0d5 gsignal + 53
5  libc.so.6       0x00007f1e7550d83b abort + 379
6  clang           0x000000000182c967
7  clang           0x0000000002021104
8  clang           0x0000000001fc7884
9  clang           0x0000000001fce192 llvm::SelectionDAG::LegalizeTypes() + 2082
10 clang           0x0000000001f9006b
llvm::SelectionDAGISel::CodeGenAndEmitDAG() + 1947
11 clang           0x0000000001f8f284
llvm::SelectionDAGISel::SelectAllBasicBlocks(llvm::Function const&) + 7140
12 clang           0x0000000001f8c2fa
llvm::SelectionDAGISel::runOnMachineFunction(llvm::MachineFunction&) + 2090
13 clang           0x00000000009bf8c1
14 clang           0x000000000124d9d9
llvm::MachineFunctionPass::runOnFunction(llvm::Function&) + 153
15 clang           0x00000000014935e5
llvm::FPPassManager::runOnFunction(llvm::Function&) + 549
16 clang           0x000000000149382b
llvm::FPPassManager::runOnModule(llvm::Module&) + 43
17 clang           0x0000000001493cf5
llvm::legacy::PassManagerImpl::run(llvm::Module&) + 869
18 clang           0x00000000019bc1ad
clang::EmitBackendOutput(clang::DiagnosticsEngine&, clang::CodeGenOptions
const&, clang::TargetOptions const&, clang::LangOptions const&, llvm::StringRef,
llvm::Module*, clang::BackendAction, llvm::raw_pwrite_stream*) + 9581
19 clang           0x0000000002047a52
20 clang           0x0000000001d9d7ac
clang::MultiplexConsumer::HandleTranslationUnit(clang::ASTContext&) + 44
21 clang           0x00000000023ee076 clang::ParseAST(clang::Sema&, bool, bool)
+ 598
22 clang           0x0000000001d64365 clang::FrontendAction::Execute() + 69
23 clang           0x0000000001d2eb61
clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) + 1153
24 clang           0x0000000001df880d
clang::ExecuteCompilerInvocation(clang::CompilerInstance*) + 3245
25 clang           0x0000000000738d82 cc1_main(llvm::ArrayRef<char const*>, char
const*, void*) + 1170
26 clang           0x0000000000737886 main + 12390
27 libc.so.6       0x00007f1e754f576d __libc_start_main + 237
28 clang           0x0000000000734715
Stack dump:
0.	Program arguments:
/b/build/slave/android_clang_dbg_recipe/build/src/third_party/llvm-build/Release+Asserts/bin/clang
-cc1 -triple armv7--linux-android -emit-obj -disable-free -main-file-name
Lzma2Dec.c -mrelocation-model pic -pic-level 2 -mthread-model posix
-mdisable-fp-elim -relaxed-aliasing -fmath-errno -masm-verbose
-mconstructor-aliases -munwind-tables -fuse-init-array -target-cpu cortex-a8
-target-feature +soft-float-abi -target-feature -fp-only-sp -target-feature -d16
-target-feature +vfp3 -target-feature -fp16 -target-feature -vfp4
-target-feature -fp-armv8 -target-feature +neon -target-feature -crypto
-target-abi aapcs-linux -mfloat-abi soft -dwarf-column-info -debugger-tuning=gdb
-ffunction-sections -fdata-sections -coverage-file
/b/build/slave/android_clang_dbg_recipe/build/src/out/Debug/obj/third_party/lzma_sdk/lzma_sdk.Lzma2Dec.o
-resource-dir
/b/build/slave/android_clang_dbg_recipe/build/src/third_party/llvm-build/Release+Asserts/bin/../lib/clang/3.9.0
-dependency-file obj/third_party/lzma_sdk/lzma_sdk.Lzma2Dec.o.d -MT
obj/third_party/lzma_sdk/lzma_sdk.Lzma2Dec.o -D V8_DEPRECATION_WARNINGS -D
CLD_VERSION=2 -D _FILE_OFFSET_BITS=64 -D NO_TCMALLOC -D DISABLE_NACL -D
CHROMIUM_BUILD -D CR_CLANG_REVISION=262516-1 -D COMPONENT_BUILD -D
USE_LIBJPEG_TURBO=1 -D ENABLE_WEBRTC=1 -D ENABLE_MEDIA_ROUTER=1 -D
USE_PROPRIETARY_CODECS -D ENABLE_BROWSER_CDMS -D ENABLE_CONFIGURATION_POLICY -D
ENABLE_NOTIFICATIONS -D DCHECK_ALWAYS_ON=1 -D FIELDTRIAL_TESTING_ENABLED -D
ADDRESS_SANITIZER -D MEMORY_TOOL_REPLACES_ALLOCATOR -D
MEMORY_SANITIZER_INITIAL_SIZE -D ENABLE_AUTOFILL_DIALOG=1 -D ENABLE_PRINTING=1
-D ENABLE_BASIC_PRINTING=1 -D ENABLE_SPELLCHECK=1 -D USE_BROWSER_SPELLCHECKER=1
-D ENABLE_SUPERVISED_USERS=1 -D VIDEO_HOLE=1 -D V8_USE_EXTERNAL_STARTUP_DATA -D
ENABLE_WEBVR -D SAFE_BROWSING_DB_REMOTE -D _7ZIP_ST -D _7Z_NO_METHODS_FILTERS -D
_LZMA_PROB32 -D USE_LIBPCI=1 -D USE_OPENSSL=1 -D USE_OPENSSL_CERTS=1 -D ANDROID
-D __GNU_SOURCE=1 -D CHROME_BUILD_ID="" -D HAVE_SYS_UIO_H -D
DYNAMIC_ANNOTATIONS_ENABLED=1 -D WTF_USE_DYNAMIC_ANNOTATIONS=1 -D _DEBUG -I gen
-I ../../third_party/lzma_sdk -D __compiler_offsetof=__builtin_offsetof -D
nan=__builtin_nan -isysroot
../../third_party/android_tools/ndk//platforms/android-16/arch-arm
-internal-isystem
../../third_party/android_tools/ndk//platforms/android-16/arch-arm/usr/local/include
-internal-isystem
/b/build/slave/android_clang_dbg_recipe/build/src/third_party/llvm-build/Release+Asserts/bin/../lib/clang/3.9.0/include
-internal-externc-isystem
../../third_party/android_tools/ndk//platforms/android-16/arch-arm/include
-internal-externc-isystem
../../third_party/android_tools/ndk//platforms/android-16/arch-arm/usr/include
-Os -Werror -Wall -Wno-unused-parameter -Wno-missing-field-initializers
-Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration
-Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
-Wno-deprecated-register -Wno-inconsistent-missing-override
-Wno-shift-negative-value -Wno-self-assign -Wno-unused-variable
-fdebug-compilation-dir
/b/build/slave/android_clang_dbg_recipe/build/src/out/Debug -ferror-limit 19
-fmessage-length 0 -fvisibility hidden -femulated-tls -fsanitize=address
-fsanitize-blacklist=/b/build/slave/android_clang_dbg_recipe/build/src/third_party/llvm-build/Release+Asserts/bin/../lib/clang/3.9.0/asan_blacklist.txt
-fno-assume-sane-operator-new -stack-protector 1 -stack-protector-buffer-size 4
-fallow-half-arguments-and-returns -fno-signed-char -fobjc-runtime=gcc
-fdiagnostics-show-option -fcolor-diagnostics -vectorize-loops -vectorize-slp
-load
/b/build/slave/android_clang_dbg_recipe/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
-add-plugin find-bad-constructs -plugin-arg-find-bad-constructs check-templates
-plugin-arg-find-bad-constructs follow-macro-expansion -mllvm -asan-globals=0 -o
obj/third_party/lzma_sdk/lzma_sdk.Lzma2Dec.o -x c
../../third_party/lzma_sdk/Lzma2Dec.c 
1.	<eof> parser at end of file
2.	Code generation
3.	Running pass 'Function Pass Manager' on module
'../../third_party/lzma_sdk/Lzma2Dec.c'.
4.	Running pass 'ARM Instruction Selection' on function '@Lzma2Dec_DecodeToDic'
clang: error: unable to execute command: Aborted (core dumped)
clang: error: clang frontend command failed due to signal (use -v to see
invocation)
clang version 3.9.0 (trunk 262516)
Target: arm--linux-android
Thread model: posix
InstalledDir:
/b/build/slave/android_clang_dbg_recipe/build/src/third_party/llvm-build/Release+Asserts/bin
clang: note: diagnostic msg: PLEASE submit a bug report to http://llvm.org/bugs/
and include the crash backtrace, preprocessed source, and associated run script.
clang: note: diagnostic msg: 
********************


Looks like we saw this on the tot bots
https://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroidASan/builds...
but it's fixed on trunk :-/

[hans, 2016-03-08 00:09:16]

Description was changed from

==========
Roll Clang 261368:262516

BUG=589647
==========

to

==========
Roll Clang 261368:262818

BUG=589647
==========

[hans, 2016-03-08 00:55:05]

Not sure what's up with the purpleness..

[Nico, 2016-03-08 01:25:28]

"GOMA:clang++ compiling ../../cc/surfaces/display.cc:*ERROR*:
compiler_proxy:29447ms: No matching compiler/subprograms found in server"…i
guess goma isn't ready yet?

Anyhoo, lgtm, if the cq likes it then I think it's good.

[Nico, 2016-03-08 01:25:49]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-03-08 01:26:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1764413002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1764413002/20001

[commit-bot: I haz the power, 2016-03-08 03:23:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 03:23:30]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hans, 2016-03-08 03:48:02]

On 2016/03/08 03:23:30, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Looks like it just died.

Is it timing out? It ran for 1h 50 which is pretty long. But wouldn't the bot
say so if it's a timeout?

[Nico, 2016-03-10 14:02:17]

Description was changed from

==========
Roll Clang 261368:262818

BUG=589647
==========

to

==========
Roll Clang 261368:262839

BUG=589647
==========

[Nico, 2016-03-10 14:02:23]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-03-10 14:02:24]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1764413002/#ps40001
(title: "262839")

[Nico, 2016-03-10 14:02:24]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2016-03-10 14:02:25]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-03-10 14:02:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1764413002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1764413002/40001

[commit-bot: I haz the power, 2016-03-10 17:43:05]

Description was changed from

==========
Roll Clang 261368:262839

BUG=589647
==========

to

==========
Roll Clang 261368:262839

BUG=589647
==========

[commit-bot: I haz the power, 2016-03-10 17:43:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-10 17:44:27]

Description was changed from

==========
Roll Clang 261368:262839

BUG=589647
==========

to

==========
Roll Clang 261368:262839

BUG=589647

Committed: https://crrev.com/d2af39c0b6518f0fc3be885fbc7edabe9bfa8272
Cr-Commit-Position: refs/heads/master@{#380427}
==========

[commit-bot: I haz the power, 2016-03-10 17:44:28]

Patchset 3 (id:??) landed as
https://crrev.com/d2af39c0b6518f0fc3be885fbc7edabe9bfa8272
Cr-Commit-Position: refs/heads/master@{#380427}

[Nico, 2016-03-11 22:43:36]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1791483003/ by thakis@chromium.org.

The reason for reverting is: The new compiler has an infinite loop for some
inputs, see crbug.com/594142. This is not a good property for a compiler to
have..