Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Side by Side Diff: src/mirror-debugger.js

Issue 17644013: Fix misleading names and comments in mute local variables debugger helper (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: rebase Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2012 the V8 project authors. All rights reserved. 1 // Copyright 2006-2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1689 matching lines...) Expand 10 before | Expand all | Expand 10 after
1700 FrameMirror.prototype.evaluate = function(source, disable_break, 1700 FrameMirror.prototype.evaluate = function(source, disable_break,
1701 opt_context_object) { 1701 opt_context_object) {
1702 var result_array = %DebugEvaluate(this.break_id_, 1702 var result_array = %DebugEvaluate(this.break_id_,
1703 this.details_.frameId(), 1703 this.details_.frameId(),
1704 this.details_.inlinedFrameIndex(), 1704 this.details_.inlinedFrameIndex(),
1705 source, 1705 source,
1706 Boolean(disable_break), 1706 Boolean(disable_break),
1707 opt_context_object); 1707 opt_context_object);
1708 // Silently ignore local variables changes if the frame is optimized. 1708 // Silently ignore local variables changes if the frame is optimized.
1709 if (!this.isOptimizedFrame()) { 1709 if (!this.isOptimizedFrame()) {
1710 var local_scope_before = result_array[1]; 1710 var local_scope_on_stack = result_array[1];
1711 var local_scope_after = result_array[2]; 1711 var local_scope_modifed = result_array[2];
1712 for (var n in local_scope_after) { 1712 for (var n in local_scope_modifed) {
1713 var value_before = local_scope_before[n]; 1713 var value_on_stack = local_scope_on_stack[n];
1714 var value_after = local_scope_after[n]; 1714 var value_modifed = local_scope_modifed[n];
1715 if (value_before !== value_after) { 1715 if (value_on_stack !== value_modifed) {
1716 %SetScopeVariableValue(this.break_id_, 1716 %SetScopeVariableValue(this.break_id_,
1717 this.details_.frameId(), 1717 this.details_.frameId(),
1718 this.details_.inlinedFrameIndex(), 1718 this.details_.inlinedFrameIndex(),
1719 0, 1719 0,
1720 n, 1720 n,
1721 value_after); 1721 value_modifed);
1722 } 1722 }
1723 } 1723 }
1724 } 1724 }
1725 return MakeMirror(result_array[0]); 1725 return MakeMirror(result_array[0]);
1726 }; 1726 };
1727 1727
1728 1728
1729 FrameMirror.prototype.invocationText = function() { 1729 FrameMirror.prototype.invocationText = function() {
1730 // Format frame invoaction (receiver, function and arguments). 1730 // Format frame invoaction (receiver, function and arguments).
1731 var result = ''; 1731 var result = '';
(...skipping 930 matching lines...) Expand 10 before | Expand all | Expand 10 after
2662 } 2662 }
2663 if (!NUMBER_IS_FINITE(value)) { 2663 if (!NUMBER_IS_FINITE(value)) {
2664 if (value > 0) { 2664 if (value > 0) {
2665 return 'Infinity'; 2665 return 'Infinity';
2666 } else { 2666 } else {
2667 return '-Infinity'; 2667 return '-Infinity';
2668 } 2668 }
2669 } 2669 }
2670 return value; 2670 return value;
2671 } 2671 }
OLDNEW
« no previous file with comments | « no previous file | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698