Issue 17644004: Add --no-commit option to apply_issue for use with git on the bots.

Issue 17644004: Add --no-commit option to apply_issue for use with git on the bots. (Closed)

Created:
7 years, 6 months ago by iannucci

Modified:
7 years, 6 months ago

Reviewers:
Dirk Pranke, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Add --no-commit option to apply_issue for use with git on the bots. R=dpranke@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208574

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	apply_issue.py	View		2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/17644004/1

7 years, 6 months ago (2013-06-25 23:03:55 UTC) #4

commit-bot: I haz the power

Presubmit check for 17644004-1 failed and returned exit status 1. Running presubmit commit checks ...

7 years, 6 months ago (2013-06-25 23:05:29 UTC) #5

Presubmit check for 17644004-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
push-basic.sh failed
Command /b/commit-queue/workdir/tools/depot_tools/tests/push-basic.sh returned
non-zero exit status 1 in /b/commit-queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   1268 --:--:-- --:--:-- --:--:--  1283
TESTING: Base URL contains branch name
TESTING: git-cl push ok
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit commit checks ...

Presubmit checks passed.
Description: 'foo-quux\n\nReview URL: http://localhost:8080/5629499534213120'
Closing issue (you may be prompted for your codereview password)...
TESTING: committed code has proper description
TESTING: issue no longer has a branch
FAILURE: issue no longer has a branch


basic.sh failed
Command /b/commit-queue/workdir/tools/depot_tools/tests/basic.sh returned
non-zero exit status 1 in /b/commit-queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   1551 --:--:-- --:--:-- --:--:--  1571
TESTING: git-cl dcommits ok
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit commit checks ...

Presubmit checks passed.
Description: 'foo-quux\n\nReview URL: http://localhost:8080/5840605766746112'
Closing issue (you may be prompted for your codereview password)...
TESTING: dcommitted code has proper description
TESTING: issue no longer has a branch
FAILURE: issue no longer has a branch


Presubmit checks took 92.4s to calculate.

iannucci

On 2013/06/25 23:05:29, I haz the power (commit-bot) wrote: > Presubmit check for 17644004-1 failed ...

7 years, 6 months ago (2013-06-25 23:26:00 UTC) #6

On 2013/06/25 23:05:29, I haz the power (commit-bot) wrote:
> Presubmit check for 17644004-1 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> Checking out rietveld...
> Running save-description-on-failure.sh
> Running push-basic.sh
> Running upstream.sh
> Running submit-from-new-dir.sh
> Running abandon.sh
> Running submodule-merge-test.sh
> Running upload-local-tracking-branch.sh
> Running hooks.sh
> Running post-dcommit-hook-test.sh
> Running upload-stale.sh
> Running patch.sh
> Running basic.sh
> 
> ** Presubmit ERRORS **
> push-basic.sh failed
> Command /b/commit-queue/workdir/tools/depot_tools/tests/push-basic.sh returned
> non-zero exit status 1 in /b/commit-queue/workdir/tools/depot_tools/tests
> Setting up test upstream git repo...
> Setting up test git repo...
> TESTING: git-cl upload wants a server
> TESTING: git-cl status has no issue
> TESTING: upload succeeds (needs a server running on localhost)
> TESTING: git-cl status now knows the issue
>   % Total    % Received % Xferd  Average Speed   Time    Time     Time 
Current
>                                  Dload  Upload   Total   Spent    Left  Speed
> 
>   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
> 0
> 100    77    0     0  100    77      0   1268 --:--:-- --:--:-- --:--:--  1283
> TESTING: Base URL contains branch name
> TESTING: git-cl push ok
> Using 50% similarity for rename/copy detection. Override with --similarity.
> Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
> Running presubmit commit checks ...
> 
> Presubmit checks passed.
> Description: 'foo-quux\n\nReview URL:
http://localhost:8080/5629499534213120%27
> Closing issue (you may be prompted for your codereview password)...
> TESTING: committed code has proper description
> TESTING: issue no longer has a branch
> FAILURE: issue no longer has a branch
> 
> 
> basic.sh failed
> Command /b/commit-queue/workdir/tools/depot_tools/tests/basic.sh returned
> non-zero exit status 1 in /b/commit-queue/workdir/tools/depot_tools/tests
> Setting up test SVN repo...
> Setting up test git-svn repo...
> TESTING: git-cl upload wants a server
> TESTING: git-cl status has no issue
> TESTING: upload succeeds (needs a server running on localhost)
> TESTING: git-cl status now knows the issue
>   % Total    % Received % Xferd  Average Speed   Time    Time     Time 
Current
>                                  Dload  Upload   Total   Spent    Left  Speed
> 
>   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
> 0
> 100    77    0     0  100    77      0   1551 --:--:-- --:--:-- --:--:--  1571
> TESTING: git-cl dcommits ok
> Using 50% similarity for rename/copy detection. Override with --similarity.
> Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
> Running presubmit commit checks ...
> 
> Presubmit checks passed.
> Description: 'foo-quux\n\nReview URL:
http://localhost:8080/5840605766746112%27
> Closing issue (you may be prompted for your codereview password)...
> TESTING: dcommitted code has proper description
> TESTING: issue no longer has a branch
> FAILURE: issue no longer has a branch
> 
> 
> Presubmit checks took 92.4s to calculate.

I think this is breaking due to https://chromiumcodereview.appspot.com/14104005/

dcommitting for now

Message was sent while issue was closed.

Committed patchset #1 manually as r208574.

Expand Messages | Collapse Messages