Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1764333002: Move WebRuntimeEnabledFeatures to platform. (Closed)

Created:
4 years, 9 months ago by esprehn
Modified:
3 years, 7 months ago
CC:
avayvod+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, horo+watch_chromium.org, jam, jochen+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+watch, kinuko+serviceworker, mcasas+watch_chromium.org, michaeln, mkwst+moarreviews-shell_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-media_chromium.org, mlamouri+watch-test-runner_chromium.org, nasko+codewatch_chromium.org, nhiroki, Peter Beverloo, piman+watch_chromium.org, posciak+watch_chromium.org, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move WebRuntimeEnabledFeatures to platform. This only uses platform anyway, so lets move it there. A follow up patch can actually merge RuntimeEnabledFeatures into WebRuntimeEnabledFeatures and we could just code generate the whole thing. BUG=561879

Patch Set 1 #

Patch Set 2 : missing files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -523 lines) Patch
M chrome/renderer/chrome_render_process_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/runtime_features.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/service_worker/web_service_worker_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/media_source_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/render_view_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/render_widget.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/renderer_main_platform_delegate_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/layout_test/layout_test_render_process_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/blink_test_environment.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_blink_web_unit_test_support.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/dispatcher.cc View 2 chunks +1 line, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -328 lines 0 comments Download
M third_party/WebKit/Source/web/web.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 2 chunks +1 line, -1 line 0 comments Download
A third_party/WebKit/public/platform/WebRuntimeFeatures.h View 1 1 chunk +175 lines, -0 lines 0 comments Download
D third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 chunk +0 lines, -175 lines 0 comments Download

Messages

Total messages: 26 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764333002/20001
4 years, 9 months ago (2016-03-04 21:55:06 UTC) #2
esprehn
4 years, 9 months ago (2016-03-04 22:06:41 UTC) #4
dglazkov
lgtm
4 years, 9 months ago (2016-03-04 22:09:32 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/184420)
4 years, 9 months ago (2016-03-05 01:28:03 UTC) #7
esprehn
4 years, 9 months ago (2016-03-05 05:12:10 UTC) #9
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-07 12:01:51 UTC) #10
sky
When you add a reviewer, please indicate what files you want them to review. I'm ...
4 years, 9 months ago (2016-03-07 16:28:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764333002/20001
4 years, 9 months ago (2016-03-07 18:33:16 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/153956)
4 years, 9 months ago (2016-03-07 18:50:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764333002/20001
4 years, 9 months ago (2016-03-18 05:09:27 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/174398) ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-18 05:11:42 UTC) #19
esprehn
dglazkov@ This is still worth doing.
3 years, 7 months ago (2017-05-11 22:56:35 UTC) #20
haraken
Stuart: Not at all urgent, but would you take over this CL in your team?
3 years, 7 months ago (2017-05-15 15:47:18 UTC) #22
slangley
sure - leave it with us. On Tue, May 16, 2017 at 1:47 AM, <haraken@chromium.org> ...
3 years, 7 months ago (2017-05-17 04:14:54 UTC) #23
slangley
sure - leave it with us. On Tue, May 16, 2017 at 1:47 AM, <haraken@chromium.org> ...
3 years, 7 months ago (2017-05-17 04:22:07 UTC) #24
slangley
https://bugs.chromium.org/p/chromium/issues/detail?id=723482 On Wed, May 17, 2017 at 2:14 PM, Stuart Langley <slangley@chromium.org> wrote: > sure ...
3 years, 7 months ago (2017-05-17 07:16:05 UTC) #25
slangley
3 years, 7 months ago (2017-05-17 07:16:06 UTC) #26
Message was sent while issue was closed.
https://bugs.chromium.org/p/chromium/issues/detail?id=723482

On Wed, May 17, 2017 at 2:14 PM, Stuart Langley <slangley@chromium.org>
wrote:

> sure - leave it with us.
>
> On Tue, May 16, 2017 at 1:47 AM, <haraken@chromium.org> wrote:
>
>> Stuart: Not at all urgent, but would you take over this CL in your team?
>>
>>
>>
>> https://codereview.chromium.org/1764333002/
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698