Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 17642011: Reland "Remove IsInitialized checks from inlined API functions." (Closed)

Created:
7 years, 6 months ago by Michael Starzinger
Modified:
7 years, 6 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Reland "Remove IsInitialized checks from inlined API functions." The initialization sequence in Blink has been adapted to use explicit isolate initialization instead of through calling v8::Null() as the first API call. R=svenpanne@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15311

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -58 lines) Patch
M include/v8.h View 8 chunks +11 lines, -11 lines 0 comments Download
M src/api.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +0 lines, -45 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 6 months ago (2013-06-25 07:51:02 UTC) #1
Sven Panne
lgtm
7 years, 6 months ago (2013-06-25 07:51:50 UTC) #2
Michael Starzinger
7 years, 6 months ago (2013-06-25 08:11:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15311 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698