CPUProfiler: propagate scriptId to the front-end

include/v8-profiler.h

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 57 matching lines @@
 typedef uint32_t SnapshotObjectId;
 
 /**
  * CpuProfileNode represents a node in a call graph.
  */
 class V8EXPORT CpuProfileNode {
  public:
   /** Returns function name (empty string for anonymous functions.) */
   Handle<String> GetFunctionName() const;
 
+  /** Returns id of the script where function is located. */
+  int GetScriptId() const;

[yurys, 2013/06/25 09:16:55]

In v8.h Script::Id returns v8::Local<v8::Value> and internally it seems to be
stored as i::String:
https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/objects-inl....
I think we should be consistent with v8::Script::Id() type here and use
Local<Value> as the return type.

Or if it is always int internally we could deprecate v8::Local<v8::Value>
v8::Script::Id() and introduce int v8::Script::GetId() instead.

+
   /** Returns resource name for script from where the function originates. */
   Handle<String> GetScriptResourceName() const;
 
   /**
    * Returns the number, 1-based, of the line where the function originates.
    * kNoLineNumberInfo if no line number information is available.
    */
   int GetLineNumber() const;
 
   /**
@@ skipping 19 matching lines @@
 
   /** Returns id of the node. The id is unique within the tree */
   unsigned GetNodeId() const;
 
   /** Returns child nodes count of the node. */
   int GetChildrenCount() const;
 
   /** Retrieves a child node by index. */
   const CpuProfileNode* GetChild(int index) const;
 
+  static const int kNoScriptId = 0;
   static const int kNoLineNumberInfo = Message::kNoLineNumberInfo;
 };
 
 
 /**
  * CpuProfile contains a CPU profile in a form of top-down call tree
  * (from main() down to functions that do all the work).
  */
 class V8EXPORT CpuProfile {
  public:
@@ skipping 472 matching lines @@
 };
 
 
 }  // namespace v8
 
 
 #undef V8EXPORT
 
 
 #endif  // V8_V8_PROFILER_H_