Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 17642005: Remove unused arguments from storage-related Chromium impls of Blink API (Closed)

Created:
7 years, 6 months ago by adamk
Modified:
7 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Remove unused arguments from storage-related Chromium impls of Blink API Also remove related unused session storage creation test harness code. This is the Chromium side of the blink-side http://crrev.com/17583016 R=darin@chromium.org, jsbell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209001

Patch Set 1 #

Patch Set 2 : Merged to trunk #

Patch Set 3 : Rebased after r208825 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -32 lines) Patch
M content/child/indexed_db/proxy_webidbfactory_impl.h View 1 2 1 chunk +3 lines, -6 lines 0 comments Download
M content/child/indexed_db/proxy_webidbfactory_impl.cc View 1 2 3 chunks +3 lines, -10 lines 0 comments Download
M content/ppapi_plugin/ppapi_webkitplatformsupport_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/ppapi_plugin/ppapi_webkitplatformsupport_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/worker/worker_webkitplatformsupport_impl.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/worker/worker_webkitplatformsupport_impl.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
jsbell
IDB changes LGTM
7 years, 6 months ago (2013-06-25 00:12:02 UTC) #1
adamk
+darin for content OWNERS.
7 years, 6 months ago (2013-06-26 21:43:24 UTC) #2
darin (slow to review)
LGTM
7 years, 6 months ago (2013-06-26 21:44:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/17642005/3001
7 years, 6 months ago (2013-06-26 21:56:03 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=20868
7 years, 5 months ago (2013-06-27 06:47:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/17642005/3001
7 years, 5 months ago (2013-06-27 16:21:59 UTC) #6
commit-bot: I haz the power
Failed to apply patch for content/child/indexed_db/proxy_webidbfactory_impl.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 5 months ago (2013-06-27 16:22:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/17642005/3001
7 years, 5 months ago (2013-06-27 18:05:31 UTC) #8
commit-bot: I haz the power
Failed to apply patch for content/child/indexed_db/proxy_webidbfactory_impl.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 5 months ago (2013-06-27 18:05:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/17642005/32001
7 years, 5 months ago (2013-06-27 19:13:26 UTC) #10
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 5 months ago (2013-06-27 19:21:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/17642005/32001
7 years, 5 months ago (2013-06-27 20:52:27 UTC) #12
adamk
7 years, 5 months ago (2013-06-27 21:06:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 manually as r209001 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698