Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 17642: Irregexp-32: Fixes us of "enter" opcode. (Closed)

Created:
11 years, 11 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

The "enter" opcode was slow and crashes for large arguments on Windows.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -31 lines) Patch
M src/regexp-macro-assembler-ia32.h View 1 chunk +16 lines, -13 lines 0 comments Download
M src/regexp-macro-assembler-ia32.cc View 8 chunks +23 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
No more enter. No more leave. You like, no?
11 years, 11 months ago (2009-01-13 10:06:54 UTC) #1
Erik Corry
11 years, 11 months ago (2009-01-13 10:15:13 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698