Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1764153002: S390: Initial impl of full-codegen (Closed)

Created:
4 years, 9 months ago by john.yan
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : S390: Initial impl of full-codegen #

Patch Set 3 : rebased on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+783 lines, -844 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +6 lines, -0 lines 0 comments Download
A + src/full-codegen/s390/full-codegen-s390.cc View 1 2 167 chunks +775 lines, -844 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 26 (12 generated)
john.yan
S390: Initial impl of full-codegen
4 years, 9 months ago (2016-03-04 15:57:17 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1764153002/diff/1/src/full-codegen/s390/full-codegen-s390.cc File src/full-codegen/s390/full-codegen-s390.cc (right): https://codereview.chromium.org/1764153002/diff/1/src/full-codegen/s390/full-codegen-s390.cc#newcode7 src/full-codegen/s390/full-codegen-s390.cc:7: #include "src/full-codegen/full-codegen.h" why did you move the header up?
4 years, 9 months ago (2016-03-04 16:09:55 UTC) #2
john.yan
On 2016/03/04 16:09:55, jochen wrote: > https://codereview.chromium.org/1764153002/diff/1/src/full-codegen/s390/full-codegen-s390.cc > File src/full-codegen/s390/full-codegen-s390.cc (right): > > https://codereview.chromium.org/1764153002/diff/1/src/full-codegen/s390/full-codegen-s390.cc#newcode7 > ...
4 years, 9 months ago (2016-03-04 16:21:22 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764153002/20001
4 years, 9 months ago (2016-03-04 20:38:29 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-04 21:03:29 UTC) #7
jochen (gone - plz use gerrit)
i'm not an owner of the full-codegen directory, but the gn/gyp changes lgtm
4 years, 9 months ago (2016-03-07 11:56:08 UTC) #9
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-07 12:04:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764153002/20001
4 years, 9 months ago (2016-03-07 13:01:49 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/16414) v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, ...
4 years, 9 months ago (2016-03-07 13:03:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764153002/20001
4 years, 9 months ago (2016-03-07 13:10:58 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/14764) v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, ...
4 years, 9 months ago (2016-03-07 13:12:36 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764153002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764153002/40001
4 years, 9 months ago (2016-03-07 13:14:01 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-07 14:00:08 UTC) #23
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 14:01:39 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/667107a5f64e1dfb303fa2139bd4d3cfa357ef81
Cr-Commit-Position: refs/heads/master@{#34541}

Powered by Google App Engine
This is Rietveld 408576698