Revert of Delete old files after an update.

Revert of Delete old files after an update. (patchset #11 id:200001 of https://codereview.chromium.org/1666363002/ )

Reason for revert:
This has caused memory errors to be reported on DrMemory. The errors are in GenerateSpecificPEFileVersion, and relate to the VisitResourceContext not being properly initialized.

Turns out you're just really unlucky, until now nobody was actually using that (or GenerateAlternatePEFileVersion, which looks like it would have the same problem).

This is the bot where it started happening:
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%285%29/builds/6716

This is some sample error output:
[----------] 10 tests from DeleteOldVersionsTest
[ RUN      ] DeleteOldVersionsTest.DeleteOldExecutableWithoutMatchingDirectory
~~Dr.M~~
~~Dr.M~~ Error #1: UNINITIALIZED READ: reading register cl
~~Dr.M~~ # 0 `anonymous namespace'::ReplaceAll                                          [chrome\installer\test\alternate_version_generator.cc:296]
~~Dr.M~~ # 1 `anonymous namespace'::VisitResource                                       [chrome\installer\test\alternate_version_generator.cc:356]
~~Dr.M~~ # 2 `anonymous namespace'::EnumResourcesWorker                                 [chrome\installer\test\pe_image_resources.cc:96]
~~Dr.M~~ # 3 `anonymous namespace'::EnumResourcesWorker                                 [chrome\installer\test\pe_image_resources.cc:84]
~~Dr.M~~ # 4 `anonymous namespace'::EnumResourcesWorker                                 [chrome\installer\test\pe_image_resources.cc:84]
~~Dr.M~~ # 5 upgrade_test::EnumResources                                                [chrome\installer\test\pe_image_resources.cc:122]
~~Dr.M~~ # 6 `anonymous namespace'::UpdateVersionIfMatch                                [chrome\installer\test\alternate_version_generator.cc:401]
~~Dr.M~~ # 7 upgrade_test::GenerateSpecificPEFileVersion                                [chrome\installer\test\alternate_version_generator.cc:769]
~~Dr.M~~ # 8 installer::`anonymous namespace'::DeleteOldVersionsTest::CreateExecutable  [chrome\installer\util\delete_old_versions_unittest.cc:66]
~~Dr.M~~ # 9 installer::DeleteOldVersionsTest_DeleteOldExecutableWithoutMatchingDirectory_Test::TestBody [chrome\installer\util\delete_old_versions_unittest.cc:129]
~~Dr.M~~ #10 testing::internal::HandleExceptionsInMethodIfSupported<>                   [testing\gtest\src\gtest.cc:2458]
~~Dr.M~~ Note: @0:00:21.478 in thread 5132
~~Dr.M~~ Note: instruction: cmp    %cl (%eax)
~~Dr.M~~
~~Dr.M~~ Error #2: UNINITIALIZED READ: reading register cl
~~Dr.M~~ # 0 `anonymous namespace'::ReplaceAll                                          [chrome\installer\test\alternate_version_generator.cc:296]
~~Dr.M~~ # 1 `anonymous namespace'::VisitResource                                       [chrome\installer\test\alternate_version_generator.cc:365]
~~Dr.M~~ # 2 `anonymous namespace'::EnumResourcesWorker                                 [chrome\installer\test\pe_image_resources.cc:96]
~~Dr.M~~ # 3 `anonymous namespace'::EnumResourcesWorker                                 [chrome\installer\test\pe_image_resources.cc:84]
~~Dr.M~~ # 4 `anonymous namespace'::EnumResourcesWorker                                 [chrome\installer\test\pe_image_resources.cc:84]
~~Dr.M~~ # 5 upgrade_test::EnumResources                                                [chrome\installer\test\pe_image_resources.cc:122]
~~Dr.M~~ # 6 `anonymous namespace'::UpdateVersionIfMatch                                [chrome\installer\test\alternate_version_generator.cc:401]
~~Dr.M~~ # 7 upgrade_test::GenerateSpecificPEFileVersion                                [chrome\installer\test\alternate_version_generator.cc:769]
~~Dr.M~~ # 8 installer::`anonymous namespace'::DeleteOldVersionsTest::CreateExecutable  [chrome\installer\util\delete_old_versions_unittest.cc:66]
~~Dr.M~~ # 9 installer::DeleteOldVersionsTest_DeleteOldExecutableWithoutMatchingDirectory_Test::TestBody [chrome\installer\util\delete_old_versions_unittest.cc:129]
~~Dr.M~~ #10 testing::internal::HandleExceptionsInMethodIfSupported<>                   [testing\gtest\src\gtest.cc:2458]
~~Dr.M~~ Note: @0:00:21.483 in thread 5132
~~Dr.M~~ Note: instruction: cmp    %cl (%eax)

Original issue's description:
> Delete old files after an update.
>
> This CL introduces a WorkItem which deletes old executables and version
> directories from the Chrome installation directory.
>
> For now, the WorkItem is used at the end of an update and at the
> end of a new_chrome.exe->chrome.exe rename. Eventually, it will also
> be invoked repetitively from a cleanup process launched when the
> WorkItem fails to delete everything the first time.
>
> BUG=451546
>
> Committed: https://crrev.com/1b50c70773051b24925b46bab8b006e606633c5c
> Cr-Commit-Position: refs/heads/master@{#378802}

TBR=grt@chromium.org,fdoray@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=451546
Committed: https://crrev.com/41bf8722c65c82d340143a5b51c3102fe828a114
Cr-Commit-Position: refs/heads/master@{#379232}

[benwells, 2016-03-04 05:54:36]

Created Revert of Delete old files after an update.

[commit-bot: I haz the power, 2016-03-04 05:54:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1764053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1764053002/1

[commit-bot: I haz the power, 2016-03-04 06:01:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1764053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1764053002/1

[commit-bot: I haz the power, 2016-03-04 06:31:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1764053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1764053002/1

[commit-bot: I haz the power, 2016-03-04 06:43:35]

Description was changed from

==========
Revert of Delete old files after an update. (patchset #11 id:200001 of
https://codereview.chromium.org/1666363002/ )

Reason for revert:
This has caused memory errors to be reported on DrMemory. The errors are in
GenerateSpecificPEFileVersion, and relate to the VisitResourceContext not being
properly initialized.

Turns out you're just really unlucky, until now nobody was actually using that
(or GenerateAlternatePEFileVersion, which looks like it would have the same
problem).

This is the bot where it started happening:
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%2...

This is some sample error output:
[----------] 10 tests from DeleteOldVersionsTest
[ RUN      ] DeleteOldVersionsTest.DeleteOldExecutableWithoutMatchingDirectory
~~Dr.M~~ 
~~Dr.M~~ Error #1: UNINITIALIZED READ: reading register cl
~~Dr.M~~ # 0 `anonymous namespace'::ReplaceAll                                  
       [chrome\installer\test\alternate_version_generator.cc:296]
~~Dr.M~~ # 1 `anonymous namespace'::VisitResource                               
       [chrome\installer\test\alternate_version_generator.cc:356]
~~Dr.M~~ # 2 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:96]
~~Dr.M~~ # 3 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:84]
~~Dr.M~~ # 4 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:84]
~~Dr.M~~ # 5 upgrade_test::EnumResources                                        
       [chrome\installer\test\pe_image_resources.cc:122]
~~Dr.M~~ # 6 `anonymous namespace'::UpdateVersionIfMatch                        
       [chrome\installer\test\alternate_version_generator.cc:401]
~~Dr.M~~ # 7 upgrade_test::GenerateSpecificPEFileVersion                        
       [chrome\installer\test\alternate_version_generator.cc:769]
~~Dr.M~~ # 8 installer::`anonymous
namespace'::DeleteOldVersionsTest::CreateExecutable 
[chrome\installer\util\delete_old_versions_unittest.cc:66]
~~Dr.M~~ # 9
installer::DeleteOldVersionsTest_DeleteOldExecutableWithoutMatchingDirectory_Test::TestBody
[chrome\installer\util\delete_old_versions_unittest.cc:129]
~~Dr.M~~ #10 testing::internal::HandleExceptionsInMethodIfSupported<>           
       [testing\gtest\src\gtest.cc:2458]
~~Dr.M~~ Note: @0:00:21.478 in thread 5132
~~Dr.M~~ Note: instruction: cmp    %cl (%eax)
~~Dr.M~~ 
~~Dr.M~~ Error #2: UNINITIALIZED READ: reading register cl
~~Dr.M~~ # 0 `anonymous namespace'::ReplaceAll                                  
       [chrome\installer\test\alternate_version_generator.cc:296]
~~Dr.M~~ # 1 `anonymous namespace'::VisitResource                               
       [chrome\installer\test\alternate_version_generator.cc:365]
~~Dr.M~~ # 2 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:96]
~~Dr.M~~ # 3 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:84]
~~Dr.M~~ # 4 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:84]
~~Dr.M~~ # 5 upgrade_test::EnumResources                                        
       [chrome\installer\test\pe_image_resources.cc:122]
~~Dr.M~~ # 6 `anonymous namespace'::UpdateVersionIfMatch                        
       [chrome\installer\test\alternate_version_generator.cc:401]
~~Dr.M~~ # 7 upgrade_test::GenerateSpecificPEFileVersion                        
       [chrome\installer\test\alternate_version_generator.cc:769]
~~Dr.M~~ # 8 installer::`anonymous
namespace'::DeleteOldVersionsTest::CreateExecutable 
[chrome\installer\util\delete_old_versions_unittest.cc:66]
~~Dr.M~~ # 9
installer::DeleteOldVersionsTest_DeleteOldExecutableWithoutMatchingDirectory_Test::TestBody
[chrome\installer\util\delete_old_versions_unittest.cc:129]
~~Dr.M~~ #10 testing::internal::HandleExceptionsInMethodIfSupported<>           
       [testing\gtest\src\gtest.cc:2458]
~~Dr.M~~ Note: @0:00:21.483 in thread 5132
~~Dr.M~~ Note: instruction: cmp    %cl (%eax)


Original issue's description:
> Delete old files after an update.
> 
> This CL introduces a WorkItem which deletes old executables and version
> directories from the Chrome installation directory.
> 
> For now, the WorkItem is used at the end of an update and at the
> end of a new_chrome.exe->chrome.exe rename. Eventually, it will also
> be invoked repetitively from a cleanup process launched when the
> WorkItem fails to delete everything the first time.
> 
> BUG=451546
> 
> Committed: https://crrev.com/1b50c70773051b24925b46bab8b006e606633c5c
> Cr-Commit-Position: refs/heads/master@{#378802}

TBR=grt@chromium.org,fdoray@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=451546
==========

to

==========
Revert of Delete old files after an update. (patchset #11 id:200001 of
https://codereview.chromium.org/1666363002/ )

Reason for revert:
This has caused memory errors to be reported on DrMemory. The errors are in
GenerateSpecificPEFileVersion, and relate to the VisitResourceContext not being
properly initialized.

Turns out you're just really unlucky, until now nobody was actually using that
(or GenerateAlternatePEFileVersion, which looks like it would have the same
problem).

This is the bot where it started happening:
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%2...

This is some sample error output:
[----------] 10 tests from DeleteOldVersionsTest
[ RUN      ] DeleteOldVersionsTest.DeleteOldExecutableWithoutMatchingDirectory
~~Dr.M~~ 
~~Dr.M~~ Error #1: UNINITIALIZED READ: reading register cl
~~Dr.M~~ # 0 `anonymous namespace'::ReplaceAll                                  
       [chrome\installer\test\alternate_version_generator.cc:296]
~~Dr.M~~ # 1 `anonymous namespace'::VisitResource                               
       [chrome\installer\test\alternate_version_generator.cc:356]
~~Dr.M~~ # 2 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:96]
~~Dr.M~~ # 3 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:84]
~~Dr.M~~ # 4 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:84]
~~Dr.M~~ # 5 upgrade_test::EnumResources                                        
       [chrome\installer\test\pe_image_resources.cc:122]
~~Dr.M~~ # 6 `anonymous namespace'::UpdateVersionIfMatch                        
       [chrome\installer\test\alternate_version_generator.cc:401]
~~Dr.M~~ # 7 upgrade_test::GenerateSpecificPEFileVersion                        
       [chrome\installer\test\alternate_version_generator.cc:769]
~~Dr.M~~ # 8 installer::`anonymous
namespace'::DeleteOldVersionsTest::CreateExecutable 
[chrome\installer\util\delete_old_versions_unittest.cc:66]
~~Dr.M~~ # 9
installer::DeleteOldVersionsTest_DeleteOldExecutableWithoutMatchingDirectory_Test::TestBody
[chrome\installer\util\delete_old_versions_unittest.cc:129]
~~Dr.M~~ #10 testing::internal::HandleExceptionsInMethodIfSupported<>           
       [testing\gtest\src\gtest.cc:2458]
~~Dr.M~~ Note: @0:00:21.478 in thread 5132
~~Dr.M~~ Note: instruction: cmp    %cl (%eax)
~~Dr.M~~ 
~~Dr.M~~ Error #2: UNINITIALIZED READ: reading register cl
~~Dr.M~~ # 0 `anonymous namespace'::ReplaceAll                                  
       [chrome\installer\test\alternate_version_generator.cc:296]
~~Dr.M~~ # 1 `anonymous namespace'::VisitResource                               
       [chrome\installer\test\alternate_version_generator.cc:365]
~~Dr.M~~ # 2 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:96]
~~Dr.M~~ # 3 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:84]
~~Dr.M~~ # 4 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:84]
~~Dr.M~~ # 5 upgrade_test::EnumResources                                        
       [chrome\installer\test\pe_image_resources.cc:122]
~~Dr.M~~ # 6 `anonymous namespace'::UpdateVersionIfMatch                        
       [chrome\installer\test\alternate_version_generator.cc:401]
~~Dr.M~~ # 7 upgrade_test::GenerateSpecificPEFileVersion                        
       [chrome\installer\test\alternate_version_generator.cc:769]
~~Dr.M~~ # 8 installer::`anonymous
namespace'::DeleteOldVersionsTest::CreateExecutable 
[chrome\installer\util\delete_old_versions_unittest.cc:66]
~~Dr.M~~ # 9
installer::DeleteOldVersionsTest_DeleteOldExecutableWithoutMatchingDirectory_Test::TestBody
[chrome\installer\util\delete_old_versions_unittest.cc:129]
~~Dr.M~~ #10 testing::internal::HandleExceptionsInMethodIfSupported<>           
       [testing\gtest\src\gtest.cc:2458]
~~Dr.M~~ Note: @0:00:21.483 in thread 5132
~~Dr.M~~ Note: instruction: cmp    %cl (%eax)


Original issue's description:
> Delete old files after an update.
> 
> This CL introduces a WorkItem which deletes old executables and version
> directories from the Chrome installation directory.
> 
> For now, the WorkItem is used at the end of an update and at the
> end of a new_chrome.exe->chrome.exe rename. Eventually, it will also
> be invoked repetitively from a cleanup process launched when the
> WorkItem fails to delete everything the first time.
> 
> BUG=451546
> 
> Committed: https://crrev.com/1b50c70773051b24925b46bab8b006e606633c5c
> Cr-Commit-Position: refs/heads/master@{#378802}

TBR=grt@chromium.org,fdoray@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=451546
==========

[commit-bot: I haz the power, 2016-03-04 06:43:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-04 06:45:35]

Description was changed from

==========
Revert of Delete old files after an update. (patchset #11 id:200001 of
https://codereview.chromium.org/1666363002/ )

Reason for revert:
This has caused memory errors to be reported on DrMemory. The errors are in
GenerateSpecificPEFileVersion, and relate to the VisitResourceContext not being
properly initialized.

Turns out you're just really unlucky, until now nobody was actually using that
(or GenerateAlternatePEFileVersion, which looks like it would have the same
problem).

This is the bot where it started happening:
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%2...

This is some sample error output:
[----------] 10 tests from DeleteOldVersionsTest
[ RUN      ] DeleteOldVersionsTest.DeleteOldExecutableWithoutMatchingDirectory
~~Dr.M~~ 
~~Dr.M~~ Error #1: UNINITIALIZED READ: reading register cl
~~Dr.M~~ # 0 `anonymous namespace'::ReplaceAll                                  
       [chrome\installer\test\alternate_version_generator.cc:296]
~~Dr.M~~ # 1 `anonymous namespace'::VisitResource                               
       [chrome\installer\test\alternate_version_generator.cc:356]
~~Dr.M~~ # 2 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:96]
~~Dr.M~~ # 3 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:84]
~~Dr.M~~ # 4 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:84]
~~Dr.M~~ # 5 upgrade_test::EnumResources                                        
       [chrome\installer\test\pe_image_resources.cc:122]
~~Dr.M~~ # 6 `anonymous namespace'::UpdateVersionIfMatch                        
       [chrome\installer\test\alternate_version_generator.cc:401]
~~Dr.M~~ # 7 upgrade_test::GenerateSpecificPEFileVersion                        
       [chrome\installer\test\alternate_version_generator.cc:769]
~~Dr.M~~ # 8 installer::`anonymous
namespace'::DeleteOldVersionsTest::CreateExecutable 
[chrome\installer\util\delete_old_versions_unittest.cc:66]
~~Dr.M~~ # 9
installer::DeleteOldVersionsTest_DeleteOldExecutableWithoutMatchingDirectory_Test::TestBody
[chrome\installer\util\delete_old_versions_unittest.cc:129]
~~Dr.M~~ #10 testing::internal::HandleExceptionsInMethodIfSupported<>           
       [testing\gtest\src\gtest.cc:2458]
~~Dr.M~~ Note: @0:00:21.478 in thread 5132
~~Dr.M~~ Note: instruction: cmp    %cl (%eax)
~~Dr.M~~ 
~~Dr.M~~ Error #2: UNINITIALIZED READ: reading register cl
~~Dr.M~~ # 0 `anonymous namespace'::ReplaceAll                                  
       [chrome\installer\test\alternate_version_generator.cc:296]
~~Dr.M~~ # 1 `anonymous namespace'::VisitResource                               
       [chrome\installer\test\alternate_version_generator.cc:365]
~~Dr.M~~ # 2 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:96]
~~Dr.M~~ # 3 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:84]
~~Dr.M~~ # 4 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:84]
~~Dr.M~~ # 5 upgrade_test::EnumResources                                        
       [chrome\installer\test\pe_image_resources.cc:122]
~~Dr.M~~ # 6 `anonymous namespace'::UpdateVersionIfMatch                        
       [chrome\installer\test\alternate_version_generator.cc:401]
~~Dr.M~~ # 7 upgrade_test::GenerateSpecificPEFileVersion                        
       [chrome\installer\test\alternate_version_generator.cc:769]
~~Dr.M~~ # 8 installer::`anonymous
namespace'::DeleteOldVersionsTest::CreateExecutable 
[chrome\installer\util\delete_old_versions_unittest.cc:66]
~~Dr.M~~ # 9
installer::DeleteOldVersionsTest_DeleteOldExecutableWithoutMatchingDirectory_Test::TestBody
[chrome\installer\util\delete_old_versions_unittest.cc:129]
~~Dr.M~~ #10 testing::internal::HandleExceptionsInMethodIfSupported<>           
       [testing\gtest\src\gtest.cc:2458]
~~Dr.M~~ Note: @0:00:21.483 in thread 5132
~~Dr.M~~ Note: instruction: cmp    %cl (%eax)


Original issue's description:
> Delete old files after an update.
> 
> This CL introduces a WorkItem which deletes old executables and version
> directories from the Chrome installation directory.
> 
> For now, the WorkItem is used at the end of an update and at the
> end of a new_chrome.exe->chrome.exe rename. Eventually, it will also
> be invoked repetitively from a cleanup process launched when the
> WorkItem fails to delete everything the first time.
> 
> BUG=451546
> 
> Committed: https://crrev.com/1b50c70773051b24925b46bab8b006e606633c5c
> Cr-Commit-Position: refs/heads/master@{#378802}

TBR=grt@chromium.org,fdoray@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=451546
==========

to

==========
Revert of Delete old files after an update. (patchset #11 id:200001 of
https://codereview.chromium.org/1666363002/ )

Reason for revert:
This has caused memory errors to be reported on DrMemory. The errors are in
GenerateSpecificPEFileVersion, and relate to the VisitResourceContext not being
properly initialized.

Turns out you're just really unlucky, until now nobody was actually using that
(or GenerateAlternatePEFileVersion, which looks like it would have the same
problem).

This is the bot where it started happening:
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%2...

This is some sample error output:
[----------] 10 tests from DeleteOldVersionsTest
[ RUN      ] DeleteOldVersionsTest.DeleteOldExecutableWithoutMatchingDirectory
~~Dr.M~~
~~Dr.M~~ Error #1: UNINITIALIZED READ: reading register cl
~~Dr.M~~ # 0 `anonymous namespace'::ReplaceAll                                  
       [chrome\installer\test\alternate_version_generator.cc:296]
~~Dr.M~~ # 1 `anonymous namespace'::VisitResource                               
       [chrome\installer\test\alternate_version_generator.cc:356]
~~Dr.M~~ # 2 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:96]
~~Dr.M~~ # 3 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:84]
~~Dr.M~~ # 4 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:84]
~~Dr.M~~ # 5 upgrade_test::EnumResources                                        
       [chrome\installer\test\pe_image_resources.cc:122]
~~Dr.M~~ # 6 `anonymous namespace'::UpdateVersionIfMatch                        
       [chrome\installer\test\alternate_version_generator.cc:401]
~~Dr.M~~ # 7 upgrade_test::GenerateSpecificPEFileVersion                        
       [chrome\installer\test\alternate_version_generator.cc:769]
~~Dr.M~~ # 8 installer::`anonymous
namespace'::DeleteOldVersionsTest::CreateExecutable 
[chrome\installer\util\delete_old_versions_unittest.cc:66]
~~Dr.M~~ # 9
installer::DeleteOldVersionsTest_DeleteOldExecutableWithoutMatchingDirectory_Test::TestBody
[chrome\installer\util\delete_old_versions_unittest.cc:129]
~~Dr.M~~ #10 testing::internal::HandleExceptionsInMethodIfSupported<>           
       [testing\gtest\src\gtest.cc:2458]
~~Dr.M~~ Note: @0:00:21.478 in thread 5132
~~Dr.M~~ Note: instruction: cmp    %cl (%eax)
~~Dr.M~~
~~Dr.M~~ Error #2: UNINITIALIZED READ: reading register cl
~~Dr.M~~ # 0 `anonymous namespace'::ReplaceAll                                  
       [chrome\installer\test\alternate_version_generator.cc:296]
~~Dr.M~~ # 1 `anonymous namespace'::VisitResource                               
       [chrome\installer\test\alternate_version_generator.cc:365]
~~Dr.M~~ # 2 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:96]
~~Dr.M~~ # 3 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:84]
~~Dr.M~~ # 4 `anonymous namespace'::EnumResourcesWorker                         
       [chrome\installer\test\pe_image_resources.cc:84]
~~Dr.M~~ # 5 upgrade_test::EnumResources                                        
       [chrome\installer\test\pe_image_resources.cc:122]
~~Dr.M~~ # 6 `anonymous namespace'::UpdateVersionIfMatch                        
       [chrome\installer\test\alternate_version_generator.cc:401]
~~Dr.M~~ # 7 upgrade_test::GenerateSpecificPEFileVersion                        
       [chrome\installer\test\alternate_version_generator.cc:769]
~~Dr.M~~ # 8 installer::`anonymous
namespace'::DeleteOldVersionsTest::CreateExecutable 
[chrome\installer\util\delete_old_versions_unittest.cc:66]
~~Dr.M~~ # 9
installer::DeleteOldVersionsTest_DeleteOldExecutableWithoutMatchingDirectory_Test::TestBody
[chrome\installer\util\delete_old_versions_unittest.cc:129]
~~Dr.M~~ #10 testing::internal::HandleExceptionsInMethodIfSupported<>           
       [testing\gtest\src\gtest.cc:2458]
~~Dr.M~~ Note: @0:00:21.483 in thread 5132
~~Dr.M~~ Note: instruction: cmp    %cl (%eax)

Original issue's description:
> Delete old files after an update.
>
> This CL introduces a WorkItem which deletes old executables and version
> directories from the Chrome installation directory.
>
> For now, the WorkItem is used at the end of an update and at the
> end of a new_chrome.exe->chrome.exe rename. Eventually, it will also
> be invoked repetitively from a cleanup process launched when the
> WorkItem fails to delete everything the first time.
>
> BUG=451546
>
> Committed: https://crrev.com/1b50c70773051b24925b46bab8b006e606633c5c
> Cr-Commit-Position: refs/heads/master@{#378802}

TBR=grt@chromium.org,fdoray@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=451546

Committed: https://crrev.com/41bf8722c65c82d340143a5b51c3102fe828a114
Cr-Commit-Position: refs/heads/master@{#379232}
==========

[commit-bot: I haz the power, 2016-03-04 06:45:36]

Patchset 1 (id:??) landed as
https://crrev.com/41bf8722c65c82d340143a5b51c3102fe828a114
Cr-Commit-Position: refs/heads/master@{#379232}