Update a webview plugin's WebView's lifecycle immediately after resizing.

components/plugins/renderer/webview_plugin.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/plugins/renderer/webview_plugin.h"
 
 #include <stddef.h>
 
 #include "base/auto_reset.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 39 matching lines @@
 
 WebViewPlugin::WebViewPlugin(content::RenderView* render_view,
                              WebViewPlugin::Delegate* delegate,
                              const WebPreferences& preferences)
     : content::RenderViewObserver(render_view),
       delegate_(delegate),
       container_(nullptr),
       web_view_(WebView::create(this)),
       finished_loading_(false),
       focused_(false),
-      is_painting_(false) {
+      is_painting_(false),
+      is_resizing_(false) {
   // ApplyWebPreferences before making a WebLocalFrame so that the frame sees a
   // consistent view of our preferences.
   content::RenderView::ApplyWebPreferences(preferences, web_view_);
   WebLocalFrame* web_local_frame =
       WebLocalFrame::create(blink::WebTreeScopeType::Document, this);
   web_frame_ = web_local_frame;
   web_view_->setMainFrame(web_frame_);
   // TODO(dcheng): The main frame widget currently has a special case.
   // Eliminate this once WebView is no longer a WebWidget.
   web_frame_widget_ = WebFrameWidget::create(this, web_view_, web_local_frame);
@@ skipping 121 matching lines @@
 
   canvas->restore();
 }
 
 // Coordinates are relative to the containing window.
 void WebViewPlugin::updateGeometry(const WebRect& window_rect,
                                    const WebRect& clip_rect,
                                    const WebRect& unobscured_rect,
                                    const WebVector<WebRect>& cut_outs_rects,
                                    bool is_visible) {
+  base::AutoReset<bool> is_resizing(
+        &is_resizing_, true);
+
   if (static_cast<gfx::Rect>(window_rect) != rect_) {
     rect_ = window_rect;
     WebSize newSize(window_rect.width, window_rect.height);
     web_view_->resize(newSize);
   }
 
-  if (delegate_)
+  if (delegate_) {
     delegate_->OnUnobscuredRectUpdate(gfx::Rect(unobscured_rect));
+    // The delegate may have dirtied style and layout of the WebView.
+    // See for example the resizePoster function in plugin_poster.html.
+    // Run the lifecycle now so that it is clean.
+    web_view_->updateAllLifecyclePhases();

[leviw_travelin_and_unemployed, 2016/03/04 19:24:58]

When all you've got is a hammer :p

+  }
 }
 
 void WebViewPlugin::updateFocus(bool focused, blink::WebFocusType focus_type) {
   focused_ = focused;
 }
 
 bool WebViewPlugin::acceptsInputEvents() { return true; }
 
 blink::WebInputEventResult WebViewPlugin::handleInputEvent(
     const WebInputEvent& event,
@@ skipping 66 matching lines @@
 void WebViewPlugin::didInvalidateRect(const WebRect& rect) {
   if (container_)
     container_->invalidateRect(rect);
 }
 
 void WebViewPlugin::didChangeCursor(const WebCursorInfo& cursor) {
   current_cursor_ = cursor;
 }
 
 void WebViewPlugin::scheduleAnimation() {
+  // Resizes must be self-contained: any lifecycle updating must
+  // be triggerd from within the WebView or this WebViewPlugin.
+  // This is because this WebViewPlugin is contained in another
+  // Web View which may be in the middle of updating its lifecycle,
+  // but after layout is done, and it is illegal to dirty earlier
+  // lifecycle stages during later ones.
+  if (is_resizing_)
+    return;
   if (container_) {
     // This should never happen; see also crbug.com/545039 for context.
     CHECK(!is_painting_);
     container_->setNeedsLayout();
   }
 }
 
 void WebViewPlugin::didClearWindowObject(WebLocalFrame* frame) {
   if (!delegate_)
     return;
@@ skipping 19 matching lines @@
   // By default RenderViewObservers are destroyed along with the RenderView.
   // WebViewPlugin has a custom destruction mechanism, so we disable this.
 }
 
 void WebViewPlugin::OnZoomLevelChanged() {
   if (container_) {
     web_view_->setZoomLevel(
       blink::WebView::zoomFactorToZoomLevel(container_->pageZoomFactor()));
   }
 }