Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1764023003: [compiler] Move JSFunction post-instantiation tasks. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Move JSFunction post-instantiation tasks. This moves the post-instantiation work performed on newly allocated JSFunction objects into the Compiler class. The aim is to eventually have all decisions how to compile functions be centralized within the compiler pipeline. R=mvstanton@chromium.org Committed: https://crrev.com/1d7da9c6395cd82a4bb37cd0d2a6bc94b701348d Cr-Commit-Position: refs/heads/master@{#34550}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -31 lines) Patch
M src/compiler.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler.cc View 1 2 chunks +35 lines, -2 lines 0 comments Download
M src/factory.cc View 1 chunk +2 lines, -29 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Starzinger
4 years, 9 months ago (2016-03-04 13:53:21 UTC) #1
mvstanton
lgtm
4 years, 9 months ago (2016-03-07 10:58:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764023003/20001
4 years, 9 months ago (2016-03-07 16:22:05 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-07 16:26:13 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 16:26:35 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1d7da9c6395cd82a4bb37cd0d2a6bc94b701348d
Cr-Commit-Position: refs/heads/master@{#34550}

Powered by Google App Engine
This is Rietveld 408576698