Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 1764013002: [turbofan] do not emit 2 operations for int64 add with overflow (Closed)

Created:
4 years, 9 months ago by Mircea Trofin
Modified:
4 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] do not emit 2 operations for int64 add with overflow Do not emit 2 operations for int64 add with overflow. BUG= Committed: https://crrev.com/53a393b5d1c57bd0ac5e79a2141a6790ebcafa47 Cr-Commit-Position: refs/heads/master@{#34473}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/x64/instruction-selector-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Mircea Trofin
Similar to the other instance we found earlier.
4 years, 9 months ago (2016-03-04 02:38:19 UTC) #3
Benedikt Meurer
lgtm
4 years, 9 months ago (2016-03-04 03:24:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1764013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1764013002/20001
4 years, 9 months ago (2016-03-04 03:59:43 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-04 04:02:08 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 04:02:49 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/53a393b5d1c57bd0ac5e79a2141a6790ebcafa47
Cr-Commit-Position: refs/heads/master@{#34473}

Powered by Google App Engine
This is Rietveld 408576698