Remove COLOR_STATUS_BAR_TEXT.

chrome/browser/ui/views/status_bubble_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/status_bubble_views.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/i18n/rtl.h"
@@ skipping 402 matching lines @@
   canvas->sk_canvas()->drawRRect(rrect, shadow_paint);
 
   const int shadow_size = 2 * kShadowThickness;
   // Draw the bubble.
   rect.SetRect(SkIntToScalar(kShadowThickness), SkIntToScalar(kShadowThickness),
                SkIntToScalar(width - shadow_size),
                SkIntToScalar(height - shadow_size));
   rrect.setRectRadii(RectToSkRect(rect), (const SkVector*)rad);
   canvas->sk_canvas()->drawRRect(rrect, paint);
 
-  // Draw highlight text and then the text body. In order to make sure the text
-  // is aligned to the right on RTL UIs, we mirror the text bounds if the
-  // locale is RTL.
+  // Compute text bounds.
   const gfx::FontList font_list;
   int text_width =
       std::min(gfx::GetStringWidth(text_, font_list),
                width - shadow_size - kTextPositionX - kTextHorizPadding);
   int text_height = height - shadow_size;
-  gfx::Rect body_bounds(kShadowThickness + kTextPositionX,
+  gfx::Rect text_bounds(kShadowThickness + kTextPositionX,
                         kShadowThickness,
                         std::max(0, text_width),
                         std::max(0, text_height));
-  body_bounds.set_x(GetMirroredXForRect(body_bounds));
+  // Make sure the text is aligned to the right on RTL UIs.
+  text_bounds.set_x(GetMirroredXForRect(text_bounds));
+
+  // Text color is the foreground tab text color at 50% alpha.
   SkColor text_color =
-      theme_provider_->GetColor(ThemeProperties::COLOR_STATUS_BAR_TEXT);
-  canvas->DrawStringRect(text_, font_list, text_color, body_bounds);
+      theme_provider_->GetColor(ThemeProperties::COLOR_TAB_TEXT);

[Evan Stade, 2016/03/04 04:22:16]

I tried this out on GTK theme mode and yea, it looks fine, if you assume the
classic theme also looks fine. But honestly I don't know why we don't just use
tab text color full stop (100% alpha). Can we ask a designer if that's OK?

I'm somewhat worried that this calculation will leave us with unreadable text in
some cases (not enough contrast). At the very least we should use
color_utils::GetReadableColor() but it would be easier (and imo looks fine) to
just use normal tab text color.

[Peter Kasting, 2016/03/04 05:53:46]

We use this intentionally because we're trying to avoid drawing attention to the
status bar text.  We found early on that the status bar was super distracting
and we want to at least minimize that effect.  It's been this was since at least
2009 on all non-Linux platforms, so I think it's fine; Linux just went under the
radar.

+  canvas->DrawStringRect(text_, font_list,
+                         SkColorSetA(text_color, SkColorGetA(text_color) / 2),
+                         text_bounds);
 }
 
 
 // StatusBubbleViews::StatusViewAnimation --------------------------------------
 
 StatusBubbleViews::StatusViewAnimation::StatusViewAnimation(
     StatusView* status_view,
     double opacity_start,
     double opacity_end)
     : gfx::LinearAnimation(kFramerate, this),
@@ skipping 437 matching lines @@
 void StatusBubbleViews::SetBubbleWidth(int width) {
   size_.set_width(width);
   SetBounds(original_position_.x(), original_position_.y(),
             size_.width(), size_.height());
 }
 
 void StatusBubbleViews::CancelExpandTimer() {
   if (expand_timer_factory_.HasWeakPtrs())
     expand_timer_factory_.InvalidateWeakPtrs();
 }