Source/core/svg/graphics/SVGImage.cpp - Issue 17640007: Refactoring: Simplify DocumentWriter by reorganizing its lifetime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/graphics/SVGImage.cpp

Issue 17640007: Refactoring: Simplify DocumentWriter by reorganizing its lifetime. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed a build breakage Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/graphics/SVGImage.cpp

diff --git a/Source/core/svg/graphics/SVGImage.cpp b/Source/core/svg/graphics/SVGImage.cpp

index 1a96062555c07d557ab36d7f79a74587379b0aa7..02d551fbcd796449fc7a6ea9835b1ddbfcecd4e6 100644

--- a/Source/core/svg/graphics/SVGImage.cpp

+++ b/Source/core/svg/graphics/SVGImage.cpp

@@ -355,7 +355,7 @@ bool SVGImage::dataChanged(bool allDataReceived)

ASSERT(loader->activeDocumentLoader()); // DocumentLoader should have been created by frame->init().

DocumentWriter* writer = loader->activeDocumentLoader()->beginWriting("image/svg+xml", "UTF-8");

writer->addData(data()->data(), data()->size());

- writer->end();

+ loader->activeDocumentLoader()->endWriting(writer);

// Set the intrinsic size before a container size is available.

m_intrinsicSize = containerSize();

}