Source/core/inspector/InspectorOverlay.cpp - Issue 17640007: Refactoring: Simplify DocumentWriter by reorganizing its lifetime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorOverlay.cpp

Issue 17640007: Refactoring: Simplify DocumentWriter by reorganizing its lifetime. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed a build breakage Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/inspector/InspectorOverlay.cpp

diff --git a/Source/core/inspector/InspectorOverlay.cpp b/Source/core/inspector/InspectorOverlay.cpp

index 786159256f2047b4959f40116fb902906245ee8d..d53f216912b8aaf2912018283572501ba69711e5 100644

--- a/Source/core/inspector/InspectorOverlay.cpp

+++ b/Source/core/inspector/InspectorOverlay.cpp

@@ -563,7 +563,7 @@ Page* InspectorOverlay::overlayPage()

ASSERT(loader->activeDocumentLoader());

DocumentWriter* writer = loader->activeDocumentLoader()->beginWriting("text/html", "UTF-8");

writer->addData(reinterpret_cast<const char*>(InspectorOverlayPage_html), sizeof(InspectorOverlayPage_html));

- writer->end();

+ loader->activeDocumentLoader()->endWriting(writer);

v8::HandleScope handleScope;

v8::Handle<v8::Context> frameContext = frame->script()->currentWorldContext();

v8::Context::Scope contextScope(frameContext);