Source/core/testing/MockPagePopupDriver.cpp - Issue 17640007: Refactoring: Simplify DocumentWriter by reorganizing its lifetime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/testing/MockPagePopupDriver.cpp

Issue 17640007: Refactoring: Simplify DocumentWriter by reorganizing its lifetime. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Re-landing after fixing ASAN failure on set-parent-src-synchronously.xhtml. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/testing/MockPagePopupDriver.cpp

diff --git a/Source/core/testing/MockPagePopupDriver.cpp b/Source/core/testing/MockPagePopupDriver.cpp

index 3e6b354a14ab911d78ecc56d2fcc6b20974616cb..4c2fc5be9acf44d94fdb14d4f8e75fcd2af8936b 100644

--- a/Source/core/testing/MockPagePopupDriver.cpp

+++ b/Source/core/testing/MockPagePopupDriver.cpp

@@ -73,7 +73,7 @@ inline MockPagePopup::MockPagePopup(PagePopupClient* client, const IntRect& orig

const char scriptToSetUpPagePopupController[] = "<script>window.pagePopupController = parent.internals.pagePopupController;</script>";

writer->addData(scriptToSetUpPagePopupController, sizeof(scriptToSetUpPagePopupController));

m_popupClient->writeDocument(*writer);

- writer->end();

+ contentFrame->loader()->activeDocumentLoader()->endWriting(writer);

}

PassRefPtr<MockPagePopup> MockPagePopup::create(PagePopupClient* client, const IntRect& originBoundsInRootView, Frame* mainFrame)

« no previous file with comments | « Source/core/testing/Internals.idl ('k') | no next file » | no next file with comments »