Issue 17640: Fixed problem with unsigned number on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17640: Fixed problem with unsigned number on Windows. (Closed)

Created:
11 years, 11 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Unsigned number can't be negated in the VisualStudio compiler. Fixed a few earlier review comments that had slipped through.

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -31 lines)			Patch
	M	src/regexp-macro-assembler-ia32.h	View	1	1 chunk	+16 lines, -13 lines	0 comments	Download
	M	src/regexp-macro-assembler-ia32.cc	View	1	8 chunks	+23 lines, -18 lines	0 comments	Download

Total messages: 3 (0 generated)

Lasse Reichstein

Alternative fix to http://codereview.chromium.org/17609 Please review.

11 years, 11 months ago (2009-01-13 08:12:04 UTC) #1

Lasse Reichstein

11 years, 11 months ago (2009-01-13 10:03:55 UTC) #3

Ignore patch-set two. It should have been a new issue!