Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Unified Diff: printing/backend/printing_info_win.h

Issue 1763983002: Change scoped_ptr to a type alias for std::unique_ptr on OS_WIN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/memory/scoped_ptr.h ('k') | remoting/host/input_injector_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/backend/printing_info_win.h
diff --git a/printing/backend/printing_info_win.h b/printing/backend/printing_info_win.h
index c91d837724935c352d36861faca9531ffce88346..896ed12a763be49d43e5cee6baa25431ed0a0c8d 100644
--- a/printing/backend/printing_info_win.h
+++ b/printing/backend/printing_info_win.h
@@ -26,7 +26,7 @@ class PrinterInfo {
public:
bool Init(HANDLE printer) {
buffer_.reset(GetPrinterInfo(printer, level));
- return buffer_;
+ return buffer_ != nullptr;
Vitaly Buka (NO REVIEWS) 2016/03/04 18:25:17 is any warning without this? I thought Chromium pr
dcheng 2016/03/04 18:28:59 It depends on the reviewer =P With C++11 and expl
Vitaly Buka (NO REVIEWS) 2016/03/04 18:34:39 Thanks. I like !! too, but current one is lgtm too
joedow 2016/03/04 20:46:19 I like !! as well to boolify but I have seen feedb
}
const PrinterInfoType* get() const {
@@ -44,7 +44,7 @@ class DriverInfo {
public:
bool Init(HANDLE printer) {
buffer_.reset(GetDriverInfo(printer, level));
- return buffer_;
+ return buffer_ != nullptr;
}
const DriverInfoType* get() const {
« no previous file with comments | « base/memory/scoped_ptr.h ('k') | remoting/host/input_injector_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698