Chromium Code Reviews| Index: printing/backend/printing_info_win.h |
| diff --git a/printing/backend/printing_info_win.h b/printing/backend/printing_info_win.h |
| index c91d837724935c352d36861faca9531ffce88346..896ed12a763be49d43e5cee6baa25431ed0a0c8d 100644 |
| --- a/printing/backend/printing_info_win.h |
| +++ b/printing/backend/printing_info_win.h |
| @@ -26,7 +26,7 @@ class PrinterInfo { |
| public: |
| bool Init(HANDLE printer) { |
| buffer_.reset(GetPrinterInfo(printer, level)); |
| - return buffer_; |
| + return buffer_ != nullptr; |
|
Vitaly Buka (NO REVIEWS)
2016/03/04 18:25:17
is any warning without this?
I thought Chromium pr
dcheng
2016/03/04 18:28:59
It depends on the reviewer =P
With C++11 and expl
Vitaly Buka (NO REVIEWS)
2016/03/04 18:34:39
Thanks. I like !! too, but current one is lgtm too
joedow
2016/03/04 20:46:19
I like !! as well to boolify but I have seen feedb
|
| } |
| const PrinterInfoType* get() const { |
| @@ -44,7 +44,7 @@ class DriverInfo { |
| public: |
| bool Init(HANDLE printer) { |
| buffer_.reset(GetDriverInfo(printer, level)); |
| - return buffer_; |
| + return buffer_ != nullptr; |
| } |
| const DriverInfoType* get() const { |