Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1763973002: Enforce 16byte alignment in shader contexts (patchset #1 id:1 of https://codereview.chromium.org/17… (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Enforce 16byte alignment in shader contexts (patchset #1 id:1 of https://codereview.chromium.org/1759653004/ )" This reverts commit e38bcaf24b00066e167e03a5ac63cf828914d747. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1763973002 TBR= Committed: https://skia.googlesource.com/skia/+/773ceda51ca120b686ba2d1aff1b6d5173143be0

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -80 lines) Patch
M experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.h View 2 chunks +2 lines, -4 lines 0 comments Download
M experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M include/core/SkShader.h View 2 chunks +7 lines, -4 lines 0 comments Download
M include/effects/SkPerlinNoiseShader.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/core/SkBitmapProcShader.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapProcShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBlitter.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkColorFilterShader.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/core/SkColorFilterShader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkColorShader.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/core/SkComposeShader.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/core/SkComposeShader.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkDraw.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkEmptyShader.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/core/SkLightingShader.cpp View 1 4 chunks +5 lines, -6 lines 0 comments Download
M src/core/SkLocalMatrixShader.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkPictureShader.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/core/SkPictureShader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkShader.cpp View 2 chunks +15 lines, -1 line 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/image/SkImageShader.h View 2 chunks +1 line, -1 line 0 comments Download
M src/image/SkImageShader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763973002/1
4 years, 9 months ago (2016-03-04 01:51:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763973002/20001
4 years, 9 months ago (2016-03-04 02:06:26 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 02:18:30 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/773ceda51ca120b686ba2d1aff1b6d5173143be0

Powered by Google App Engine
This is Rietveld 408576698