Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: sync/internal_api/public/shared_model_type_processor.h

Issue 1763953002: [USS] Change the place where SharedModelTypeProcessor got created (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/api/model_type_service.cc ('k') | sync/internal_api/public/test/fake_model_type_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/public/shared_model_type_processor.h
diff --git a/sync/internal_api/public/shared_model_type_processor.h b/sync/internal_api/public/shared_model_type_processor.h
index db208708111363b1ebae08d107db1a7c67f63bc6..b8ad8eb8906542b13ded7dc4ded3bb02416f5b35 100644
--- a/sync/internal_api/public/shared_model_type_processor.h
+++ b/sync/internal_api/public/shared_model_type_processor.h
@@ -38,15 +38,6 @@ class SYNC_EXPORT SharedModelTypeProcessor : public ModelTypeProcessor,
SharedModelTypeProcessor(syncer::ModelType type, ModelTypeService* service);
~SharedModelTypeProcessor() override;
- typedef base::Callback<void(syncer::SyncError, scoped_ptr<ActivationContext>)>
- StartCallback;
-
- // Called by the DataTypeController to gather additional information needed
- // before a CommitQueue object can be created for this model type. Once the
- // metadata has been loaded, the info is collected and given to |callback|.
- // Once called, this can only be called again if sync is disconnected.
- void OnSyncStarting(StartCallback callback);
-
// Disconnect this processor from the sync engine. Change metadata will
// continue being processed and persisted, but no commits can be made until
// the next time sync is connected.
@@ -72,6 +63,7 @@ class SYNC_EXPORT SharedModelTypeProcessor : public ModelTypeProcessor,
void Delete(const std::string& client_tag,
MetadataChangeList* metadata_change_list) override;
void OnMetadataLoaded(scoped_ptr<MetadataBatch> batch) override;
+ void OnSyncStarting(const StartCallback& callback) override;
// Returns the long-lived WeakPtr that is intended to be registered with the
// ProfileSyncService.
« no previous file with comments | « sync/api/model_type_service.cc ('k') | sync/internal_api/public/test/fake_model_type_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698