Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: sync/api/model_type_service.cc

Issue 1763953002: [USS] Change the place where SharedModelTypeProcessor got created (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sky's review Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/api/model_type_service.cc
diff --git a/sync/api/model_type_service.cc b/sync/api/model_type_service.cc
index 87df14bf6011dc559b98e90082d0e2d29f1235d7..8c2735cdd94ccfb1f6292981474e042c4f7d3d8b 100644
--- a/sync/api/model_type_service.cc
+++ b/sync/api/model_type_service.cc
@@ -4,9 +4,13 @@
#include "sync/api/model_type_service.h"
+#include "sync/api/model_type_change_processor.h"
+
namespace syncer_v2 {
-ModelTypeService::ModelTypeService() {}
+ModelTypeService::ModelTypeService(
+ const ChangeProcessorFactory& change_processor_factory)
+ : change_processor_factory_(change_processor_factory) {}
ModelTypeService::~ModelTypeService() {}
@@ -14,15 +18,25 @@ ModelTypeChangeProcessor* ModelTypeService::change_processor() const {
return change_processor_.get();
}
-void ModelTypeService::set_change_processor(
- scoped_ptr<ModelTypeChangeProcessor> change_processor) {
- DCHECK(!change_processor_);
- change_processor_.swap(change_processor);
- OnChangeProcessorSet();
+ModelTypeChangeProcessor* ModelTypeService::GetOrCreateChangeProcessor() {
+ if (!change_processor_) {
+ change_processor_ = change_processor_factory_.Run(type(), this);
skym 2016/03/24 22:51:37 Cool! I didn't know this worked.
Gang Wu 2016/03/25 02:07:00 Done.
+ DCHECK(change_processor_);
+ OnChangeProcessorSet();
+ }
+ return change_processor_.get();
}
void ModelTypeService::clear_change_processor() {
change_processor_.reset();
}
+ModelTypeChangeProcessor* ModelTypeService::OnSyncStarting(
+ const ModelTypeChangeProcessor::StartCallback& start_callback) {
+ ModelTypeChangeProcessor* processor = GetOrCreateChangeProcessor();
+ DCHECK(processor);
+ processor->OnSyncStarting(start_callback);
+ return processor;
+}
+
} // namespace syncer_v2

Powered by Google App Engine
This is Rietveld 408576698