Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: components/sync_driver/non_blocking_data_type_controller.h

Issue 1763953002: [USS] Change the place where SharedModelTypeProcessor got created (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update base on Max and Sky's comment Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_driver/non_blocking_data_type_controller.h
diff --git a/components/sync_driver/non_blocking_data_type_controller.h b/components/sync_driver/non_blocking_data_type_controller.h
index d7369ac4a3a39c6b3275f96466e2e863c64ee17c..b4d754e03806a18d0abfe147dc12d7dbaaca0ccd 100644
--- a/components/sync_driver/non_blocking_data_type_controller.h
+++ b/components/sync_driver/non_blocking_data_type_controller.h
@@ -78,15 +78,11 @@ class NonBlockingDataTypeController : public sync_driver::DataTypeController {
virtual void RunOnUIThread(const tracked_objects::Location& from_here,
const base::Closure& task) = 0;
- // The function will create SharedModelTypeProcessor on model thread.
- void InitializeProcessor();
-
private:
void RecordStartFailure(ConfigureResult result) const;
void RecordUnrecoverableError();
void ReportLoadModelError(ConfigureResult result,
const syncer::SyncError& error);
- void InitializeProcessorOnModelThread();
// If the DataType controller is waiting for models to load, once the models
// are loaded this function should be called to let the base class
@@ -106,6 +102,10 @@ class NonBlockingDataTypeController : public sync_driver::DataTypeController {
syncer::SyncError error,
scoped_ptr<syncer_v2::ActivationContext> activation_context);
+ // The function LoadModels() will call this function to do some works which
+ // need to be done on model thread.
+ void LoadModelsOnModelThread();
+
// Model Type for this controller
syncer::ModelType model_type_;

Powered by Google App Engine
This is Rietveld 408576698