sync/internal_api/shared_model_type_processor.cc - Issue 1763953002: [USS] Change the place where SharedModelTypeProcessor got created

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/shared_model_type_processor.cc

Issue 1763953002: [USS] Change the place where SharedModelTypeProcessor got created (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sync/internal_api/public/test/fake_model_type_service.h ('K') | « sync/internal_api/public/test/fake_model_type_service.h ('k') | sync/internal_api/shared_model_type_processor_unittest.cc » ('j') | sync/internal_api/shared_model_type_processor_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/shared_model_type_processor.cc

diff --git a/sync/internal_api/shared_model_type_processor.cc b/sync/internal_api/shared_model_type_processor.cc

index c963a3c7a4d8e3471d58b9f8e18390e41eb4ead0..eba8aa79ac9e2bf4d132894748d7adfea7e4046e 100644

--- a/sync/internal_api/shared_model_type_processor.cc

+++ b/sync/internal_api/shared_model_type_processor.cc

@@ -80,7 +80,8 @@ SharedModelTypeProcessor::SharedModelTypeProcessor(syncer::ModelType type,

SharedModelTypeProcessor::~SharedModelTypeProcessor() {}

-void SharedModelTypeProcessor::OnSyncStarting(StartCallback start_callback) {

+void SharedModelTypeProcessor::OnSyncStarting(

+ const ModelTypeService::StartCallback& start_callback) {

DCHECK(CalledOnValidThread());

DCHECK(start_callback_.is_null());

DCHECK(!IsConnected());