components/sync_driver/device_info_service.h - Issue 1763953002: [USS] Change the place where SharedModelTypeProcessor got created

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/device_info_service.h

Issue 1763953002: [USS] Change the place where SharedModelTypeProcessor got created (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync_driver/device_info_model_type_controller.cc ('k') | components/sync_driver/device_info_service.cc » ('j') | components/sync_driver/device_info_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/device_info_service.h

diff --git a/components/sync_driver/device_info_service.h b/components/sync_driver/device_info_service.h

index 4ffc466802542029090ee4959a9219801efa4e6a..bf428651fb530158a27efabc8531006159e433c7 100644

--- a/components/sync_driver/device_info_service.h

+++ b/components/sync_driver/device_info_service.h

@@ -46,7 +46,8 @@ class DeviceInfoService : public syncer_v2::ModelTypeService,

DeviceInfoService(

sync_driver::LocalDeviceInfoProvider* local_device_info_provider,

- const StoreFactoryFunction& callback);

+ const StoreFactoryFunction& callback,

+ const SharedProcessorFactory& shared_processor_factory);

maxbogue 2016/03/22 21:40:11 change_processor_factory

Gang Wu 2016/03/24 15:56:25 Done.

~DeviceInfoService() override;

// ModelTypeService implementation.

@@ -70,6 +71,7 @@ class DeviceInfoService : public syncer_v2::ModelTypeService,

void AddObserver(Observer* observer) override;

void RemoveObserver(Observer* observer) override;

int CountActiveDevices() const override;

+ syncer::ModelType type() const override;

maxbogue 2016/03/22 21:40:12 This is in the wrong section; it should be the Mod

Gang Wu 2016/03/24 15:56:25 Done.

private:

friend class DeviceInfoServiceTest;