Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: sync/internal_api/shared_model_type_processor_unittest.cc

Issue 1763953002: [USS] Change the place where SharedModelTypeProcessor got created (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/shared_model_type_processor_unittest.cc
diff --git a/sync/internal_api/shared_model_type_processor_unittest.cc b/sync/internal_api/shared_model_type_processor_unittest.cc
index 1e6a7f79ef8dd908d928a7a77c89ea93438f56be..9907b2317c217399e56b7bbbc0bc961c2bb02d7b 100644
--- a/sync/internal_api/shared_model_type_processor_unittest.cc
+++ b/sync/internal_api/shared_model_type_processor_unittest.cc
@@ -146,10 +146,16 @@ class SharedModelTypeProcessorTest : public ::testing::Test,
~SharedModelTypeProcessorTest() override {}
+ syncer::ModelType type() const override { return kModelType; }
+
void CreateProcessor() {
ASSERT_FALSE(type_processor());
- set_change_processor(
- make_scoped_ptr(new SharedModelTypeProcessor(kModelType, this)));
+ ASSERT_TRUE(create_change_processor());
+ }
+
+ scoped_ptr<ModelTypeChangeProcessor> CreateSharedModelTypeProcessor(
+ ModelTypeService* service) {
+ return make_scoped_ptr(new SharedModelTypeProcessor(kModelType, service));
}
void InitializeToMetadataLoaded() {
@@ -356,7 +362,7 @@ class SharedModelTypeProcessorTest : public ::testing::Test,
}
// Return the number of entities the processor has metadata for.
- size_t ProcessorEntityCount() const {
+ size_t ProcessorEntityCount() {
Gang Wu 2016/03/22 17:47:51 will add const back
DCHECK(type_processor());
return type_processor()->entities_.size();
}
@@ -387,7 +393,7 @@ class SharedModelTypeProcessorTest : public ::testing::Test,
MockCommitQueue* mock_queue() { return mock_queue_; }
- SharedModelTypeProcessor* type_processor() const {
+ SharedModelTypeProcessor* type_processor() {
Gang Wu 2016/03/22 17:47:51 will add const back
return static_cast<SharedModelTypeProcessor*>(change_processor());
}

Powered by Google App Engine
This is Rietveld 408576698