Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: sync/api/model_type_service.cc

Issue 1763953002: [USS] Change the place where SharedModelTypeProcessor got created (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/api/model_type_service.h" 5 #include "sync/api/model_type_service.h"
6 6
7 #include "sync/internal_api/public/shared_model_type_processor.h"
8
7 namespace syncer_v2 { 9 namespace syncer_v2 {
8 10
9 ModelTypeService::ModelTypeService() {} 11 ModelTypeService::ModelTypeService(
12 const SharedProcessorFactory& shared_processor_factory)
13 : shared_processor_factory_(shared_processor_factory) {}
10 14
11 ModelTypeService::~ModelTypeService() {} 15 ModelTypeService::~ModelTypeService() {}
12 16
13 ModelTypeChangeProcessor* ModelTypeService::change_processor() const { 17 ModelTypeChangeProcessor* ModelTypeService::change_processor() const {
14 return change_processor_.get(); 18 return change_processor_.get();
15 } 19 }
16 20
17 void ModelTypeService::set_change_processor( 21 ModelTypeChangeProcessor* ModelTypeService::create_change_processor() {
maxbogue 2016/03/22 21:40:12 This function is doing nontrivial logic, which mea
Gang Wu 2016/03/24 15:56:26 Done.
18 scoped_ptr<ModelTypeChangeProcessor> change_processor) { 22 if (!change_processor_.get()) {
maxbogue 2016/03/22 21:40:12 I think you should just either just DCHECK(!change
skym 2016/03/22 22:18:17 +1 to GetOrCreateChangeProcessor. Checking change_
Gang Wu 2016/03/24 15:56:26 Done.
Gang Wu 2016/03/24 15:56:26 Done.
19 DCHECK(!change_processor_); 23 change_processor_.reset(
20 change_processor_.swap(change_processor); 24 shared_processor_factory_.Run(type(), this).release());
21 OnChangeProcessorSet(); 25 if (!change_processor_.get()) {
maxbogue 2016/03/22 21:40:12 Again, better to just DCHECK(change_processor_).
Gang Wu 2016/03/24 15:56:26 Done.
26 LOG(WARNING) << "Cannot initalize ModelTypeChangeProcessor.";
27 }
28 OnChangeProcessorSet();
29 }
30 return change_processor_.get();
22 } 31 }
23 32
24 void ModelTypeService::clear_change_processor() { 33 void ModelTypeService::clear_change_processor() {
25 change_processor_.reset(); 34 change_processor_.reset();
26 } 35 }
27 36
37 void ModelTypeService::OnSyncStarting(const StartCallback& start_callback) {
38 // TODO(gangwu): should not cast here, find a better way to call.
39 static_cast<SharedModelTypeProcessor*>(create_change_processor())
maxbogue 2016/03/22 21:40:12 OnSyncStarting should just be moved into the Model
Gang Wu 2016/03/24 15:56:26 Done.
40 ->OnSyncStarting(start_callback);
41 }
42
28 } // namespace syncer_v2 43 } // namespace syncer_v2
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698