Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1763923002: Remove Web Bluetooth from Experimental in M50. (Closed)

Created:
4 years, 9 months ago by scheib
Modified:
4 years, 9 months ago
CC:
blink-reviews, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, kinuko+watch, nasko+codewatch_chromium.org, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Web Bluetooth from Experimental in M50. Shipping the experiment has blockers as defined in https://crbug.com/565736 that are not satisfied in M50. This essentially reverts https://crrev.com/1662183002. When re-enabling copy the TEST instructions from there. BUG=591820 Committed: https://crrev.com/0c113ac03cbf3d44926c6584d1755a82834dd0b4 Cr-Commit-Position: refs/heads/master@{#379864}

Patch Set 1 #

Patch Set 2 : compile and virtual/stable/webexposed/global-interface-listing.html #

Patch Set 3 : merge TOT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -22 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/Bluetooth.idl View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.idl View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothCharacteristicProperties.idl View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.idl View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.idl View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.idl View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.idl View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/NavigatorBluetooth.idl View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 32 (16 generated)
scheib
4 years, 9 months ago (2016-03-03 23:26:43 UTC) #2
ortuno
lgtm but you have to fix compile errors on some platforms.
4 years, 9 months ago (2016-03-04 00:28:30 UTC) #3
ortuno
And remove the WebBluetooth errors from the interface listing test.
4 years, 9 months ago (2016-03-04 00:29:31 UTC) #4
scheib
jam: content/browser/renderer_host/render_process_host_impl.cc third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in third_party/WebKit/Source/web/WebLocalFrameImpl.cpp dglazkov: third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
4 years, 9 months ago (2016-03-04 04:23:44 UTC) #7
dglazkov
lgtm
4 years, 9 months ago (2016-03-04 04:41:36 UTC) #9
scheib
pfeldman: content/browser/renderer_host/render_process_host_impl.cc third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
4 years, 9 months ago (2016-03-07 21:36:05 UTC) #11
no sievers
content lgtm
4 years, 9 months ago (2016-03-07 22:22:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763923002/20001
4 years, 9 months ago (2016-03-07 22:24:38 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/141322) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-07 22:27:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763923002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763923002/40001
4 years, 9 months ago (2016-03-07 22:40:36 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/32299) android_compile_dbg on tryserver.chromium.android (JOB_FAILED, ...
4 years, 9 months ago (2016-03-07 22:45:08 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763923002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763923002/40001
4 years, 9 months ago (2016-03-07 23:02:15 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/34577)
4 years, 9 months ago (2016-03-08 02:16:33 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763923002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763923002/40001
4 years, 9 months ago (2016-03-08 18:13:24 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-08 18:20:50 UTC) #30
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 18:22:52 UTC) #32
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0c113ac03cbf3d44926c6584d1755a82834dd0b4
Cr-Commit-Position: refs/heads/master@{#379864}

Powered by Google App Engine
This is Rietveld 408576698