Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1763883005: Attempt to combine batches in forward direction before flush (Closed)

Created:
4 years, 9 months ago by bsalomon
Modified:
4 years, 9 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : tiny cleanup #

Total comments: 2

Patch Set 4 : fix extra space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -12 lines) Patch
M dm/DMSrcSink.cpp View 1 2 chunks +3 lines, -0 lines 0 comments Download
M include/gpu/GrContextOptions.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 5 chunks +10 lines, -6 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 3 6 chunks +59 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
bsalomon
4 years, 9 months ago (2016-03-07 16:44:15 UTC) #3
joshualitt
lgtm + https://codereview.chromium.org/1763883005/diff/40001/src/gpu/GrDrawTarget.cpp File src/gpu/GrDrawTarget.cpp (right): https://codereview.chromium.org/1763883005/diff/40001/src/gpu/GrDrawTarget.cpp#newcode56 src/gpu/GrDrawTarget.cpp:56: options.fMaxBatchLookahead ; mindless nit, alignment
4 years, 9 months ago (2016-03-07 19:01:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763883005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763883005/60001
4 years, 9 months ago (2016-03-07 19:32:28 UTC) #7
bsalomon
https://codereview.chromium.org/1763883005/diff/40001/src/gpu/GrDrawTarget.cpp File src/gpu/GrDrawTarget.cpp (right): https://codereview.chromium.org/1763883005/diff/40001/src/gpu/GrDrawTarget.cpp#newcode56 src/gpu/GrDrawTarget.cpp:56: options.fMaxBatchLookahead ; On 2016/03/07 19:01:43, joshualitt wrote: > mindless ...
4 years, 9 months ago (2016-03-07 19:32:44 UTC) #8
bsalomon
4 years, 9 months ago (2016-03-07 19:32:44 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 19:50:47 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/aecc018f86d911198b7c7775cee04f61bd10b430

Powered by Google App Engine
This is Rietveld 408576698