Pass Windows font rendering preferences from browser to blink

Pass Windows font rendering preferences from browser to blink

Change the way Blink queries Windows font settings to work reliably with
the sandbox. Instead of calling SystemParametersInfo directly from Blink
in FontPlatformDataWin do so in the browser process and pass the desired
flags to Blink using the WebFontRendering interface. Also, use the value
should_antialias_text in Chrome's RendererPreferences object rather than
checking the SPI_GETFONTSMOOTHINGTYPE Windows system parameter directly.

Similarly use the subpixel_rendering field in RendererPreferences rather
than checking FE_FONTSMOOTHINGCLEARTYPE to control use of subpixel text.

In addition to ensure that these values are queried correctly this helps
guarantee that Chrome and Blink use the same setting for text rendering.

TBR=jam@chromium.org
BUG=419003
Committed: https://crrev.com/e3fe85330f1fbad6cb02cd0c5ceb09498e50f349
Cr-Commit-Position: refs/heads/master@{#379589}

[eae, 2016-03-04 00:28:55]

Description was changed from

==========
win/aa alt

BUG=
==========

to

==========
Pass Windows font rendering preferences from browser to blink

Change the way Blink queries Windows font settings to work reliably with
the sandbox. Instead of calling SystemParametersInfo directly from Blink
in FontPlatformDataWin do so in the browser process and pass the desired
flags to Blink using the WebFontRendering interface. Also, use the value
should_antialias_text in Chrome's RendererPreferences object rather than
checking the SPI_GETFONTSMOOTHINGTYPE Windows system parameter directly.

Similarly use the subpixel_rendering field in RendererPreferences rather
than checking FE_FONTSMOOTHINGCLEARTYPE to control use of subpixel text.

In addition to ensure that these values are queried correctly this helps
guarantee that Chrome and Blink use the same setting for text rendering.

R=scottmg@chromium.org
BUG=419003
==========

[eae, 2016-03-04 00:28:55]

eae@chromium.org changed reviewers:
+ scottmg@chromium.org

[eae, 2016-03-04 00:29:59]

Description was changed from

==========
Pass Windows font rendering preferences from browser to blink

Change the way Blink queries Windows font settings to work reliably with
the sandbox. Instead of calling SystemParametersInfo directly from Blink
in FontPlatformDataWin do so in the browser process and pass the desired
flags to Blink using the WebFontRendering interface. Also, use the value
should_antialias_text in Chrome's RendererPreferences object rather than
checking the SPI_GETFONTSMOOTHINGTYPE Windows system parameter directly.

Similarly use the subpixel_rendering field in RendererPreferences rather
than checking FE_FONTSMOOTHINGCLEARTYPE to control use of subpixel text.

In addition to ensure that these values are queried correctly this helps
guarantee that Chrome and Blink use the same setting for text rendering.

R=scottmg@chromium.org
BUG=419003
==========

to

==========
Pass Windows font rendering preferences from browser to blink

Change the way Blink queries Windows font settings to work reliably with
the sandbox. Instead of calling SystemParametersInfo directly from Blink
in FontPlatformDataWin do so in the browser process and pass the desired
flags to Blink using the WebFontRendering interface. Also, use the value
should_antialias_text in Chrome's RendererPreferences object rather than
checking the SPI_GETFONTSMOOTHINGTYPE Windows system parameter directly.

Similarly use the subpixel_rendering field in RendererPreferences rather
than checking FE_FONTSMOOTHINGCLEARTYPE to control use of subpixel text.

In addition to ensure that these values are queried correctly this helps
guarantee that Chrome and Blink use the same setting for text rendering.

R=ananta@chromium.org
BUG=419003
==========

[eae, 2016-03-04 00:29:59]

eae@chromium.org changed reviewers:
+ ananta@chromium.org
- scottmg@chromium.org

[ananta, 2016-03-04 01:45:37]

lgtm

[eae, 2016-03-04 03:01:01]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-03-04 03:01:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1763803002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1763803002/20001

[commit-bot: I haz the power, 2016-03-04 03:11:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 03:11:40]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[eae, 2016-03-04 03:23:03]

eae@chromium.org changed reviewers:
+ jam@chromium.org

[eae, 2016-03-04 03:23:04]

+jam for content/renderer/render_view_win.cc approval

[scottmg, 2016-03-05 00:15:48]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2016-03-05 00:15:49]

lgtm

(jam is ooo for a week, I think this is ok to tbr, or find another content owner
if you'd like)

[eae, 2016-03-07 17:02:56]

Description was changed from

==========
Pass Windows font rendering preferences from browser to blink

Change the way Blink queries Windows font settings to work reliably with
the sandbox. Instead of calling SystemParametersInfo directly from Blink
in FontPlatformDataWin do so in the browser process and pass the desired
flags to Blink using the WebFontRendering interface. Also, use the value
should_antialias_text in Chrome's RendererPreferences object rather than
checking the SPI_GETFONTSMOOTHINGTYPE Windows system parameter directly.

Similarly use the subpixel_rendering field in RendererPreferences rather
than checking FE_FONTSMOOTHINGCLEARTYPE to control use of subpixel text.

In addition to ensure that these values are queried correctly this helps
guarantee that Chrome and Blink use the same setting for text rendering.

R=ananta@chromium.org
BUG=419003
==========

to

==========
Pass Windows font rendering preferences from browser to blink

Change the way Blink queries Windows font settings to work reliably with
the sandbox. Instead of calling SystemParametersInfo directly from Blink
in FontPlatformDataWin do so in the browser process and pass the desired
flags to Blink using the WebFontRendering interface. Also, use the value
should_antialias_text in Chrome's RendererPreferences object rather than
checking the SPI_GETFONTSMOOTHINGTYPE Windows system parameter directly.

Similarly use the subpixel_rendering field in RendererPreferences rather
than checking FE_FONTSMOOTHINGCLEARTYPE to control use of subpixel text.

In addition to ensure that these values are queried correctly this helps
guarantee that Chrome and Blink use the same setting for text rendering.

TBR=jam@chromium.org
BUG=419003
==========

[eae, 2016-03-07 17:03:06]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-03-07 17:03:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1763803002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1763803002/20001

[commit-bot: I haz the power, 2016-03-07 18:21:28]

Description was changed from

==========
Pass Windows font rendering preferences from browser to blink

Change the way Blink queries Windows font settings to work reliably with
the sandbox. Instead of calling SystemParametersInfo directly from Blink
in FontPlatformDataWin do so in the browser process and pass the desired
flags to Blink using the WebFontRendering interface. Also, use the value
should_antialias_text in Chrome's RendererPreferences object rather than
checking the SPI_GETFONTSMOOTHINGTYPE Windows system parameter directly.

Similarly use the subpixel_rendering field in RendererPreferences rather
than checking FE_FONTSMOOTHINGCLEARTYPE to control use of subpixel text.

In addition to ensure that these values are queried correctly this helps
guarantee that Chrome and Blink use the same setting for text rendering.

TBR=jam@chromium.org
BUG=419003
==========

to

==========
Pass Windows font rendering preferences from browser to blink

Change the way Blink queries Windows font settings to work reliably with
the sandbox. Instead of calling SystemParametersInfo directly from Blink
in FontPlatformDataWin do so in the browser process and pass the desired
flags to Blink using the WebFontRendering interface. Also, use the value
should_antialias_text in Chrome's RendererPreferences object rather than
checking the SPI_GETFONTSMOOTHINGTYPE Windows system parameter directly.

Similarly use the subpixel_rendering field in RendererPreferences rather
than checking FE_FONTSMOOTHINGCLEARTYPE to control use of subpixel text.

In addition to ensure that these values are queried correctly this helps
guarantee that Chrome and Blink use the same setting for text rendering.

TBR=jam@chromium.org
BUG=419003
==========

[commit-bot: I haz the power, 2016-03-07 18:21:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-07 18:22:35]

Description was changed from

==========
Pass Windows font rendering preferences from browser to blink

Change the way Blink queries Windows font settings to work reliably with
the sandbox. Instead of calling SystemParametersInfo directly from Blink
in FontPlatformDataWin do so in the browser process and pass the desired
flags to Blink using the WebFontRendering interface. Also, use the value
should_antialias_text in Chrome's RendererPreferences object rather than
checking the SPI_GETFONTSMOOTHINGTYPE Windows system parameter directly.

Similarly use the subpixel_rendering field in RendererPreferences rather
than checking FE_FONTSMOOTHINGCLEARTYPE to control use of subpixel text.

In addition to ensure that these values are queried correctly this helps
guarantee that Chrome and Blink use the same setting for text rendering.

TBR=jam@chromium.org
BUG=419003
==========

to

==========
Pass Windows font rendering preferences from browser to blink

Change the way Blink queries Windows font settings to work reliably with
the sandbox. Instead of calling SystemParametersInfo directly from Blink
in FontPlatformDataWin do so in the browser process and pass the desired
flags to Blink using the WebFontRendering interface. Also, use the value
should_antialias_text in Chrome's RendererPreferences object rather than
checking the SPI_GETFONTSMOOTHINGTYPE Windows system parameter directly.

Similarly use the subpixel_rendering field in RendererPreferences rather
than checking FE_FONTSMOOTHINGCLEARTYPE to control use of subpixel text.

In addition to ensure that these values are queried correctly this helps
guarantee that Chrome and Blink use the same setting for text rendering.

TBR=jam@chromium.org
BUG=419003

Committed: https://crrev.com/e3fe85330f1fbad6cb02cd0c5ceb09498e50f349
Cr-Commit-Position: refs/heads/master@{#379589}
==========

[commit-bot: I haz the power, 2016-03-07 18:22:37]

Patchset 2 (id:??) landed as
https://crrev.com/e3fe85330f1fbad6cb02cd0c5ceb09498e50f349
Cr-Commit-Position: refs/heads/master@{#379589}