Issue 17638009: Move C++ specific flags from C flags to C++ flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17638009: Move C++ specific flags from C flags to C++ flags (Closed)

Created:
7 years, 6 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 6 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Move C++ specific flags from C flags to C++ flags This allows to compile non-C++ files in the v8 standalone build, e.g. assembly files found in ICU. R=jkummerow@chromium.org BUG=v8:2745 Committed: http://code.google.com/p/v8/source/detail?r=15326

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	build/standalone.gypi	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

Jakob Kummerow

LGTM. Hint: in the BUG= line, you need to write "v8:1234" for the auto-linking to ...

7 years, 6 months ago (2013-06-25 13:40:40 UTC) #3

jochen (gone - plz use gerrit)

ok, will do in the future Can you please commit this for me?

7 years, 6 months ago (2013-06-25 13:48:00 UTC) #4

Jakob Kummerow

7 years, 6 months ago (2013-06-25 14:39:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r15326 (presubmit successful).