Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: webkit/glue/webview_impl.cc

Issue 17638: A quick fix for "Issue 6252: Regression: IME candidate window showing far awa... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webview_impl.cc
===================================================================
--- webkit/glue/webview_impl.cc (revision 7912)
+++ webkit/glue/webview_impl.cc (working copy)
@@ -1130,7 +1130,7 @@
const Editor* editor = focused->editor();
if (!editor || !editor->canEdit())
return false;
- const SelectionController* controller = focused->selection();
+ SelectionController* controller = focused->selection();
if (!controller)
return false;
const Node* node = controller->start().node();
@@ -1138,10 +1138,7 @@
return false;
*enable_ime = node->shouldUseInputMethod() &&
!controller->isInPasswordField();
- const FrameView* view = node->document()->view();
- if (!view)
- return false;
- const IntRect rect(view->contentsToWindow(controller->localCaretRect()));
+ const IntRect rect(controller->absoluteCaretBounds());
caret_rect->SetRect(rect.x(), rect.y(), rect.width(), rect.height());
return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698