Issue 17638: A quick fix for "Issue 6252: Regression: IME candidate window showing far awa...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17638: A quick fix for "Issue 6252: Regression: IME candidate window showing far awa... (Closed)

Created:
11 years, 11 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
jungshik at Google

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

A quick fix for "Issue 6252: Regression: IME candidate window showing far away from the input box". This issue is caused by a recent WebKit merge that changes the behavior of the ScrollView::contentsToWindow() function. To fix this issue, this change uses the SelectionController::absoluteCaretBounds() function instead of calling the ScrollView::contentsToWindow() function. BUG=6252 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8550

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	webkit/glue/webview_impl.cc	View		2 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jungshik at Google

11 years, 11 months ago (2009-01-22 18:36:58 UTC) #3

lgtm.
(sorry for the delay. I just got back from the vacation)

Expand Messages | Collapse Messages