Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1763793002: cc: ImageDecodes: Always use original decode for bilerp. (Closed)

Created:
4 years, 9 months ago by vmpstr
Modified:
4 years, 9 months ago
Reviewers:
enne (OOO), ericrk
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: ImageDecodes: Always use original decode for bilerp. Instead of extracting a subrect in case of scale, we can always use the original decode since Skia will Do The Right Thing. That is, Skia already implements a cheap subrect extraction if it needs to do it, so there is no point in replicating this logic. R=enne, ericrk BUG=591571 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/09885a2c46ae80f2e07fce7858a52c0b45f4dbb7 Cr-Commit-Position: refs/heads/master@{#379079}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -46 lines) Patch
M cc/tiles/software_image_decode_controller.cc View 4 chunks +9 lines, -46 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
vmpstr
Please take a look.
4 years, 9 months ago (2016-03-03 19:05:51 UTC) #2
enne (OOO)
What is this tested by?
4 years, 9 months ago (2016-03-03 19:15:57 UTC) #3
vmpstr
On 2016/03/03 19:15:57, enne wrote: > What is this tested by? There is pretty good ...
4 years, 9 months ago (2016-03-03 19:18:20 UTC) #4
enne (OOO)
lgtm
4 years, 9 months ago (2016-03-03 19:26:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763793002/1
4 years, 9 months ago (2016-03-03 19:52:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 20:45:38 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 20:46:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09885a2c46ae80f2e07fce7858a52c0b45f4dbb7
Cr-Commit-Position: refs/heads/master@{#379079}

Powered by Google App Engine
This is Rietveld 408576698