chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java - Issue 1763713003: Fix accessibility order of Android tabstrip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java

Issue 1763713003: Fix accessibility order of Android tabstrip (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed GN Build Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/android/AndroidManifest.xml ('K') | « chrome/android/BUILD.gn ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutTab.java » ('j') | chrome/android/junit/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java

index dd894353c49ee2f686c92708a82ae5aa5095b8fe..2bece0264769ae064a42634159fe305d1d965ba5 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java

@@ -214,8 +214,8 @@ public class StripLayoutHelper {

* @param views A List to populate with virtual views.

public void getVirtualViews(List<VirtualView> views) {

- for (int i = mStripTabsToRender.length - 1; i >= 0; i--) {

- StripLayoutTab tab = mStripTabsToRender[i];

+ for (int i = 0; i < mStripTabs.length; i++) {

+ StripLayoutTab tab = mStripTabs[i];

tab.getVirtualViews(views);

}

if (mNewTabButton.isVisible()) views.add(mNewTabButton);