build/android/AndroidManifest.xml - Issue 1763713003: Fix accessibility order of Android tabstrip

Side by Side Diff: build/android/AndroidManifest.xml

Issue 1763713003: Fix accessibility order of Android tabstrip (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed GN Build Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/BUILD.gn » ('j') | chrome/android/junit/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperTest.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!--	2 <!--

3 Copyright (c) 2012 The Chromium Authors. All rights reserved. Use of this	3 Copyright (c) 2012 The Chromium Authors. All rights reserved. Use of this

4 source code is governed by a BSD-style license that can be found in the	4 source code is governed by a BSD-style license that can be found in the

5 LICENSE file.	5 LICENSE file.

6 -->	6 -->

7	7

8 <!--	8 <!--

9 This is a dummy manifest which is required by:	9 This is a dummy manifest which is required by:

10 1. aapt when generating R.java in java.gypi:	10 1. aapt when generating R.java in java.gypi:

11 Nothing in the manifest is used, but it is still required by aapt.	11 Nothing in the manifest is used, but it is still required by aapt.

12 2. lint: [min\|target]SdkVersion are required by lint and should	12 2. lint: [min\|target]SdkVersion are required by lint and should

13 be kept up-to-date.	13 be kept up-to-date.

14 -->	14 -->

15 <manifest xmlns:android="http://schemas.android.com/apk/res/android"	15 <manifest xmlns:android="http://schemas.android.com/apk/res/android"

16 package="dummy.package">	16 package="org.chromium.chrome">
	jbudorick 2016/04/05 13:26:54 What's the motivation here? It's not obvious from What's the motivation here? It's not obvious from your gyp/gn changes why this was necessary, and if you need a particular package name here, then this is liable to break for other targets. kraush 2016/04/05 15:48:04 This is the package the R.java this Manifest is us Show quoted text On 2016/04/05 13:26:54, jbudorick wrote: > What's the motivation here? It's not obvious from your gyp/gn changes why this > was necessary, and if you need a particular package name here, then this is > liable to break for other targets. This is the package the R.java this Manifest is used for will be generated in. You are right - as soon as there is a second user of this Manifest for R generation, the package will no longer work (apk's have their own Manifests, but JUnit tests for something else than ChromePublic could run into this issue) Would you prefer me to change it to replace the file with a jinja template (with a package parameter) instead to prevent such future problems? jbudorick 2016/04/05 15:52:03 Yeah, that'd be great. Show quoted text On 2016/04/05 15:48:04, kraush wrote: > On 2016/04/05 13:26:54, jbudorick wrote: > > What's the motivation here? It's not obvious from your gyp/gn changes why this > > was necessary, and if you need a particular package name here, then this is > > liable to break for other targets. > > This is the package the R.java this Manifest is used for will be generated in. > You are right - as soon as there is a second user of this Manifest for R > generation, the package will no longer work (apk's have their own Manifests, but > JUnit tests for something else than ChromePublic could run into this issue) > > Would you prefer me to change it to replace the file with a jinja template (with > a package parameter) instead to prevent such future problems? Yeah, that'd be great. kraush 2016/04/05 18:57:47 I just looked into this some more and just realize Show quoted text On 2016/04/05 15:52:03, jbudorick wrote: > On 2016/04/05 15:48:04, kraush wrote: > > On 2016/04/05 13:26:54, jbudorick wrote: > > > What's the motivation here? It's not obvious from your gyp/gn changes why > this > > > was necessary, and if you need a particular package name here, then this is > > > liable to break for other targets. > > > > This is the package the R.java this Manifest is used for will be generated in. > > You are right - as soon as there is a second user of this Manifest for R > > generation, the package will no longer work (apk's have their own Manifests, > but > > JUnit tests for something else than ChromePublic could run into this issue) > > > > Would you prefer me to change it to replace the file with a jinja template > (with > > a package parameter) instead to prevent such future problems? > > Yeah, that'd be great. I just looked into this some more and just realized that a mechanism for this already exists (which will effectively use a different Manifest) I'll update the CL using the "custom_package" attribute rather than modifying the Manifest.
17	17

18 <uses-sdk android:minSdkVersion="16" android:targetSdkVersion="23" />	18 <uses-sdk android:minSdkVersion="16" android:targetSdkVersion="23" />

19	19

20 </manifest>	20 </manifest>

OLD	NEW