Android: Remove the prompt when entering fullscreen mode (behind flag).

Android: Remove the prompt when entering fullscreen mode (behind flag).

If the #simplified-fullscreen-ui flag is enabled, still shows the toast
(at the top of the screen), but no longer asks if you want to allow
fullscreen mode (it is implied). This is consistent with the recent
changes to fullscreen on desktop (we no longer consider it worthwhile
requiring the user to manually accept fullscreen mode).

BUG=523930
Committed: https://crrev.com/3a46edeeb8cc6b47bfd3210042964324eaf28c07
Cr-Commit-Position: refs/heads/master@{#380364}

[Matt Giuca, 2016-03-04 00:30:41]

Description was changed from

==========
Android: Remove the prompt when entering fullscreen mode.

Still shows the toast (at the top of the screen), but no longer asks if
you want to allow fullscreen mode (it is implied). This is consistent
with the recent changes to fullscreen on desktop (we no longer consider
it worthwhile requiring the user to manually accept fullscreen mode).

BUG=523930
==========

to

==========
Android: Remove the prompt when entering fullscreen mode (behind flag).

If the #simplified-fullscreen-ui flag is enabled, still shows the toast
(at the top of the screen), but no longer asks if you want to allow
fullscreen mode (it is implied). This is consistent with the recent
changes to fullscreen on desktop (we no longer consider it worthwhile
requiring the user to manually accept fullscreen mode).

BUG=523930
==========

[Matt Giuca, 2016-03-04 00:30:54]

Description was changed from

==========
Android: Remove the prompt when entering fullscreen mode (behind flag).

If the #simplified-fullscreen-ui flag is enabled, still shows the toast
(at the top of the screen), but no longer asks if you want to allow
fullscreen mode (it is implied). This is consistent with the recent
changes to fullscreen on desktop (we no longer consider it worthwhile
requiring the user to manually accept fullscreen mode).

BUG=523930
==========

to

==========
Android: Remove the prompt when entering fullscreen mode (behind flag).

If the #simplified-fullscreen-ui flag is enabled, still shows the toast
(at the top of the screen), but no longer asks if you want to allow
fullscreen mode (it is implied). This is consistent with the recent
changes to fullscreen on desktop (we no longer consider it worthwhile
requiring the user to manually accept fullscreen mode).

BUG=523930
==========

[Matt Giuca, 2016-03-04 01:12:08]

mgiuca@chromium.org changed reviewers:
+ jochen@chromium.org, scheib@chromium.org, tedchoc@chromium.org

[Matt Giuca, 2016-03-04 01:12:09]

The OWNERS here are pretty nuts: chrome/common/chrome_features.* has no OWNERS
other than chrome top-level.
chrome/android/java/src/org/chromium/chrome/browser/fullscreen has no OWNERS
other than chrome/android top-level. ¯\_(ツ)_/¯

tedchoc: Please review FullscreenHtmlApiHandler.java and chrome_feature_list.cc.
jochen: Please review chrome_features.*.
scheib: Please review exclusive_access_manager.*.

[scheib, 2016-03-04 01:35:15]

LGTM

[jochen (gone - plz use gerrit), 2016-03-04 12:54:39]

lgtm with comments

https://codereview.chromium.org/1763653002/diff/60001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/1763653002/diff/60001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:1624: {"simplified-fullscreen-ui",
IDS_FLAGS_SIMPLIFIED_FULLSCREEN_UI_NAME,
does this require an update to histograms.xml now that this flag is available
everywhere?

https://codereview.chromium.org/1763653002/diff/60001/chrome/common/chrome_fe...
File chrome/common/chrome_features.cc (right):

https://codereview.chromium.org/1763653002/diff/60001/chrome/common/chrome_fe...
chrome/common/chrome_features.cc:28: const base::Feature
kSimplifiedFullscreenUI{
is this clang-formatted?

[Matt Giuca, 2016-03-04 23:00:28]

https://codereview.chromium.org/1763653002/diff/60001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/1763653002/diff/60001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:1624: {"simplified-fullscreen-ui",
IDS_FLAGS_SIMPLIFIED_FULLSCREEN_UI_NAME,
On 2016/03/04 12:54:38, jochen wrote:
> does this require an update to histograms.xml now that this flag is available
> everywhere?

No, it doesn't look like histograms.xml has anything about what operating
systems a particular flag supports. (Unless you see something I missed?)

https://codereview.chromium.org/1763653002/diff/60001/chrome/common/chrome_fe...
File chrome/common/chrome_features.cc (right):

https://codereview.chromium.org/1763653002/diff/60001/chrome/common/chrome_fe...
chrome/common/chrome_features.cc:28: const base::Feature
kSimplifiedFullscreenUI{
On 2016/03/04 12:54:39, jochen wrote:
> is this clang-formatted?

Not sure (I was following the pattern for the rest of the file). I'll check when
back at the office.

[Matt Giuca, 2016-03-07 05:53:09]

tedchoc: Did you get a chance to look at the Android part?

https://codereview.chromium.org/1763653002/diff/60001/chrome/common/chrome_fe...
File chrome/common/chrome_features.cc (right):

https://codereview.chromium.org/1763653002/diff/60001/chrome/common/chrome_fe...
chrome/common/chrome_features.cc:28: const base::Feature
kSimplifiedFullscreenUI{
On 2016/03/04 23:00:28, Matt Giuca wrote:
> On 2016/03/04 12:54:39, jochen wrote:
> > is this clang-formatted?
> 
> Not sure (I was following the pattern for the rest of the file). I'll check
when
> back at the office.

Uh yeah, it is "kind of" clang formatted.

Without the #if defineds it formats the same as the above ones (brace without a
space; I guess intended to look like a function call). If I run clang-format
over this I get:


const base::Feature kSimplifiedFullscreenUI {
  "ViewsSimplifiedFullscreenUI",
#if defined(USE_AURA)
      // Windows, Linux, Chrome OS.
      base::FEATURE_ENABLED_BY_DEFAULT,
#else
      // Mac, Android.
      base::FEATURE_DISABLED_BY_DEFAULT,
#endif

which just looks wrong. So keeping it as-is.

[Ted C, 2016-03-07 17:46:25]

On 2016/03/07 05:53:09, Matt Giuca wrote:
> tedchoc: Did you get a chance to look at the Android part?
> 
>
https://codereview.chromium.org/1763653002/diff/60001/chrome/common/chrome_fe...
> File chrome/common/chrome_features.cc (right):
> 
>
https://codereview.chromium.org/1763653002/diff/60001/chrome/common/chrome_fe...
> chrome/common/chrome_features.cc:28: const base::Feature
> kSimplifiedFullscreenUI{
> On 2016/03/04 23:00:28, Matt Giuca wrote:
> > On 2016/03/04 12:54:39, jochen wrote:
> > > is this clang-formatted?
> > 
> > Not sure (I was following the pattern for the rest of the file). I'll check
> when
> > back at the office.
> 
> Uh yeah, it is "kind of" clang formatted.
> 
> Without the #if defineds it formats the same as the above ones (brace without
a
> space; I guess intended to look like a function call). If I run clang-format
> over this I get:
> 
> 
> const base::Feature kSimplifiedFullscreenUI {
>   "ViewsSimplifiedFullscreenUI",
> #if defined(USE_AURA)
>       // Windows, Linux, Chrome OS.
>       base::FEATURE_ENABLED_BY_DEFAULT,
> #else
>       // Mac, Android.
>       base::FEATURE_DISABLED_BY_DEFAULT,
> #endif
> 
> which just looks wrong. So keeping it as-is.

android - lgtm

[Matt Giuca, 2016-03-07 23:04:32]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2016-03-07 23:05:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1763653002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1763653002/60001

[commit-bot: I haz the power, 2016-03-07 23:08:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 23:08:23]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Matt Giuca, 2016-03-10 02:20:16]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2016-03-10 02:20:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, scheib@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1763653002/#ps80001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-03-10 02:20:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1763653002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1763653002/80001

[commit-bot: I haz the power, 2016-03-10 02:36:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 02:36:26]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Matt Giuca, 2016-03-10 05:03:40]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2016-03-10 05:03:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, scheib@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1763653002/#ps100001
(title: "Fix interactive ui tests.")

[commit-bot: I haz the power, 2016-03-10 05:03:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1763653002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1763653002/100001

[commit-bot: I haz the power, 2016-03-10 06:46:20]

Description was changed from

==========
Android: Remove the prompt when entering fullscreen mode (behind flag).

If the #simplified-fullscreen-ui flag is enabled, still shows the toast
(at the top of the screen), but no longer asks if you want to allow
fullscreen mode (it is implied). This is consistent with the recent
changes to fullscreen on desktop (we no longer consider it worthwhile
requiring the user to manually accept fullscreen mode).

BUG=523930
==========

to

==========
Android: Remove the prompt when entering fullscreen mode (behind flag).

If the #simplified-fullscreen-ui flag is enabled, still shows the toast
(at the top of the screen), but no longer asks if you want to allow
fullscreen mode (it is implied). This is consistent with the recent
changes to fullscreen on desktop (we no longer consider it worthwhile
requiring the user to manually accept fullscreen mode).

BUG=523930
==========

[commit-bot: I haz the power, 2016-03-10 06:46:21]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-10 06:47:47]

Description was changed from

==========
Android: Remove the prompt when entering fullscreen mode (behind flag).

If the #simplified-fullscreen-ui flag is enabled, still shows the toast
(at the top of the screen), but no longer asks if you want to allow
fullscreen mode (it is implied). This is consistent with the recent
changes to fullscreen on desktop (we no longer consider it worthwhile
requiring the user to manually accept fullscreen mode).

BUG=523930
==========

to

==========
Android: Remove the prompt when entering fullscreen mode (behind flag).

If the #simplified-fullscreen-ui flag is enabled, still shows the toast
(at the top of the screen), but no longer asks if you want to allow
fullscreen mode (it is implied). This is consistent with the recent
changes to fullscreen on desktop (we no longer consider it worthwhile
requiring the user to manually accept fullscreen mode).

BUG=523930

Committed: https://crrev.com/3a46edeeb8cc6b47bfd3210042964324eaf28c07
Cr-Commit-Position: refs/heads/master@{#380364}
==========

[commit-bot: I haz the power, 2016-03-10 06:47:48]

Patchset 6 (id:??) landed as
https://crrev.com/3a46edeeb8cc6b47bfd3210042964324eaf28c07
Cr-Commit-Position: refs/heads/master@{#380364}