Allow debugger evaluate expressions to mute local variables

src/mirror-debugger.js

 // Copyright 2006-2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1653 matching lines @@
 };
 
 
 FrameMirror.prototype.scope = function(index) {
   return new ScopeMirror(this, void 0, index);
 };
 
 
 FrameMirror.prototype.evaluate = function(source, disable_break,
                                           opt_context_object) {
-  var result = %DebugEvaluate(this.break_id_,
-                              this.details_.frameId(),
-                              this.details_.inlinedFrameIndex(),
-                              source,
-                              Boolean(disable_break),
-                              opt_context_object);
-  return MakeMirror(result);
+  var result_array = %DebugEvaluate(this.break_id_,
+                                   this.details_.frameId(),

[Yang, 2013/06/25 11:15:01]

indentation is off by one.

[Peter Rybin, 2013/06/25 12:22:41]

Done.

+                                   this.details_.inlinedFrameIndex(),
+                                   source,
+                                   Boolean(disable_break),
+                                   opt_context_object);
+  // TODO: Check against optimized function somehow.
+  var local_scope_before = result_array[1];
+  var local_scope_after = result_array[2];
+  for (var n in local_scope_after) {
+    var value_before = local_scope_before[n];
+    var value_after = local_scope_after[n];
+    if (value_before !== value_after) {
+      %SetScopeVariableValue(this.break_id_,
+                             this.details_.frameId(),
+                             this.details_.inlinedFrameIndex(),
+                             0,
+                             n,
+                             value_after);
+    }
+  }
+  return MakeMirror(result_array[0]);
 };
 
 
 FrameMirror.prototype.invocationText = function() {
   // Format frame invoaction (receiver, function and arguments).
   var result = '';
   var func = this.func();
   var receiver = this.receiver();
   if (this.isConstructCall()) {
     // For constructor frames display new followed by the function name.
@@ skipping 926 matching lines @@
   }
   if (!NUMBER_IS_FINITE(value)) {
     if (value > 0) {
       return 'Infinity';
     } else {
       return '-Infinity';
     }
   }
   return value;
 }