Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Unified Diff: lib/src/web_socket/channel.dart

Issue 1763583003: Deprecate WebSocketChannel. (Closed) Base URL: git@github.com:dart-lang/http_parser@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/web_socket.dart ('k') | lib/src/web_socket/compatible.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/web_socket/channel.dart
diff --git a/lib/src/web_socket/channel.dart b/lib/src/web_socket/channel.dart
index 339f06513e58f8b144e3f83b2db4f69d5311c271..fd1e3c5aae1dce0405683d6cdbc5503dfccaeb30 100644
--- a/lib/src/web_socket/channel.dart
+++ b/lib/src/web_socket/channel.dart
@@ -10,15 +10,12 @@ import 'package:stream_channel/stream_channel.dart';
import '../copy/web_socket_impl.dart';
-/// A [StreamChannel] implementation of the WebSocket protocol.
+/// This class is deprecated.
///
-/// This is not specific to `dart:io` or to any particular HTTP API. Because of
-/// that, it doesn't handle the initial [WebSocket handshake][]. This needs to
-/// be handled manually by the user of the code. Once that's been done, [new
-/// WebSocketChannel] can be called with the underlying socket and it will
-/// handle the remainder of the protocol.
+/// Use the [`web_socket_channel`][web_socket_channel] package instead.
///
-/// [WebSocket handshake]: https://tools.ietf.org/html/rfc6455#section-4
+/// [web_socket_channel]: https://pub.dartlang.org/packages/web_socket_channel
+@Deprecated("Will be removed in 3.0.0.")
class WebSocketChannel extends StreamChannelMixin {
/// The underlying web socket.
///
@@ -99,10 +96,12 @@ class WebSocketChannel extends StreamChannelMixin {
channel.stream, channel.sink, protocol, serverSide);
}
-/// The sink exposed by a [CompatibleWebSocket].
+/// This class is deprecated.
///
-/// This is like a normal [StreamSink], except that it supports extra arguments
-/// to [close].
+/// Use the [`web_socket_channel`][web_socket_channel] package instead.
+///
+/// [web_socket_channel]: https://pub.dartlang.org/packages/web_socket_channel
+@Deprecated("Will be removed in 3.0.0.")
class WebSocketSink extends DelegatingStreamSink {
final WebSocketImpl _webSocket;
« no previous file with comments | « lib/src/web_socket.dart ('k') | lib/src/web_socket/compatible.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698