third_party/WebKit/Source/core/css/RuleFeature.cpp - Issue 1763553002: Invalidate :default pseudo classes when a default button is added or removed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/RuleFeature.cpp

Issue 1763553002: Invalidate :default pseudo classes when a default button is added or removed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: return -> continue Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/pseudo-default-dynamic.html ('k') | third_party/WebKit/Source/core/html/HTMLButtonElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/RuleFeature.cpp

diff --git a/third_party/WebKit/Source/core/css/RuleFeature.cpp b/third_party/WebKit/Source/core/css/RuleFeature.cpp

index 9b08b9893cba33e57317b063378cf0216a77f722..fc8995e5abcf3ab1b72f39068a648f52f5760461 100644

--- a/third_party/WebKit/Source/core/css/RuleFeature.cpp

+++ b/third_party/WebKit/Source/core/css/RuleFeature.cpp

@@ -326,8 +326,7 @@ InvalidationSet* RuleFeatureSet::invalidationSetForSelector(const CSSSelector& s

case CSSSelector::PseudoActive:

case CSSSelector::PseudoChecked:

case CSSSelector::PseudoEnabled:

- // TODO(rune@opera.com): crbug.com/557683 :default is currently not updated dynamically.

- // case CSSSelector::Default:

+ case CSSSelector::PseudoDefault:

case CSSSelector::PseudoDisabled:

case CSSSelector::PseudoOptional:

case CSSSelector::PseudoPlaceholderShown: