third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp - Issue 1763553002: Invalidate :default pseudo classes when a default button is added or removed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

Issue 1763553002: Invalidate :default pseudo classes when a default button is added or removed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/css/pseudo-default-dynamic.html ('K') | « third_party/WebKit/Source/core/html/HTMLButtonElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLFormElement.h » ('j') | third_party/WebKit/Source/core/html/HTMLFormElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp b/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

index c91f636d2bb22d58f2fa497f1eb7f959a43d265f..842b8bd795766230ff30211b50e72cbad5237a13 100644

--- a/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

@@ -301,12 +301,16 @@ void HTMLFormControlElement::willChangeForm()

{

FormAssociatedElement::willChangeForm();

formOwnerSetNeedsValidityCheck();

+ if (formOwner() && canBeSuccessfulSubmitButton())

+ formOwner()->invalidateDefaultButtonStyle();

}

void HTMLFormControlElement::didChangeForm()

{

FormAssociatedElement::didChangeForm();

formOwnerSetNeedsValidityCheck();

+ if (formOwner() && inDocument() && canBeSuccessfulSubmitButton())

+ formOwner()->invalidateDefaultButtonStyle();

}

void HTMLFormControlElement::formOwnerSetNeedsValidityCheck()