scripts/slave/recipe_modules/chromium/api.py - Issue 17635005: Make blink_trybot recipe work on windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 17635005: Make blink_trybot recipe work on windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Fix presubmit + move polyfill (retry) Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/chromium/api.py

diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py

index 146a461e4fe150adcab041b90ff0803c062a2ba0..9608044468b0f2a177653fbd58c87e80e30847f1 100644

--- a/scripts/slave/recipe_modules/chromium/api.py

+++ b/scripts/slave/recipe_modules/chromium/api.py

@@ -34,12 +34,15 @@ class ChromiumApi(recipe_api.RecipeApi):

"""Return a runtest.py invocation."""

args = args or []

assert isinstance(args, list)

- test_args = [test] + args

python_arg = []

t_name, ext = self.m.path.splitext(self.m.path.basename(test))

if ext == '.py':

python_arg = ['--run-python-script']

+ elif self.m.platform.is_win and ext == '':

+ test += '.exe'

+ test_args = [test] + args

return self.m.step(name or t_name, [

'python', self.m.path.build('scripts', 'slave', 'runtest.py'),