Make blink_trybot recipe work on windows

scripts/slave/recipe_modules/chromium/config.py

Index: scripts/slave/recipe_modules/chromium/config.py
diff --git a/scripts/slave/recipe_modules/chromium/config.py b/scripts/slave/recipe_modules/chromium/config.py
index cd1a8cc2f26990c8fc0b70c4e5907aa3146fcb08..52daacb8044ad3f30683093655740792623aef31 100644
--- a/scripts/slave/recipe_modules/chromium/config.py
+++ b/scripts/slave/recipe_modules/chromium/config.py
@@ -62,7 +62,8 @@ HostPlatformValue = object()
 # Schema for config items in this module.
 def BaseConfig(HOST_PLATFORM=None, HOST_ARCH=None, HOST_BITS=None,
                TARGET_PLATFORM=None, TARGET_ARCH=HostPlatformValue,
-               TARGET_BITS=HostPlatformValue, BUILD_CONFIG=norm_build_config()):
+               TARGET_BITS=HostPlatformValue, BUILD_CONFIG=norm_build_config(),
+               **_kwargs):

[agable, 2013/06/25 15:55:28]

why?

[iannucci, 2013/06/25 21:22:09]

Because when you set_config(..., SOME_OPTION=Data), SOME_OPTION is passed to all
the schema functions.

   assert HOST_PLATFORM and HOST_ARCH and HOST_BITS
   TARGET_PLATFORM = TARGET_PLATFORM or HOST_PLATFORM
   TARGET_ARCH = HOST_ARCH if TARGET_ARCH is HostPlatformValue else TARGET_ARCH
@@ -79,7 +80,7 @@ def BaseConfig(HOST_PLATFORM=None, HOST_ARCH=None, HOST_BITS=None,
       GYP_GENERATORS = SetConfig(str, ','.join),
       GYP_GENERATOR_FLAGS = DictConfig(
         lambda i: ('%s=%s' % i), ' '.join, (str,int)),
-      GYP_MSVS_VERSION = SimpleConfig(str, empty_val="", required=False),
+      GYP_MSVS_VERSION = SimpleConfig(str, required=False),
     ),
     build_dir = SimpleConfig(str),