scripts/slave/recipe_modules/python/api.py - Issue 17635005: Make blink_trybot recipe work on windows

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipe_modules/python/api.py

Issue 17635005: Make blink_trybot recipe work on windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2013 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 from slave import recipe_api

	6

	7 class PythonApi(recipe_api.RecipeApi):

	8 def __call__(self, name, script, args=None, unbuffered=True, **kwargs):

	9 """Return a step to run a python script with arguments."""

	10 preamble = ['python']
	agable 2013/06/25 15:55:28 call it 'cmd' or something -- it eventually holds call it 'cmd' or something -- it eventually holds ['python', '-u', 'foo.py'] which is pretty much the main body, not a preamble. iannucci 2013/06/25 21:22:09 Done. Show quoted text On 2013/06/25 15:55:28, Aaron Gable wrote: > call it 'cmd' or something -- it eventually holds ['python', '-u', 'foo.py'] > which is pretty much the main body, not a preamble. Done.
	11 if unbuffered:

	12 preamble.append('-u')

	13 preamble.append(script)

	14 return self.m.step(name, preamble + list(args or []), **kwargs)

	15

	16 def inline(self, name, program, **kwargs):
	agable 2013/06/25 15:55:28 docstring docstring iannucci 2013/06/25 21:22:09 Good catch. Done. Show quoted text On 2013/06/25 15:55:28, Aaron Gable wrote: > docstring Good catch. Done.
	17 return self(name, recipe_api.InputDataPlaceholder(program, '.py'), **kwargs)

OLD	NEW