Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17635: Remove HttpTransactionWinHttp and the --winhttp command-line... (Closed)

Created:
11 years, 11 months ago by wtc
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Remove HttpTransactionWinHttp and the --winhttp command-line switch. Remove WinHttpThrottle and CertStatusCache, which are only used by HttpTransactionWinHttp. Fix nits reported by cpplint.py. R=eroman,darin BUG=6323 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7970

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2713 lines) Patch
M chrome/browser/browser_main.cc View 1 2 3 2 chunks +2 lines, -9 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 2 chunks +1 line, -4 lines 0 comments Download
M net/build/net.vcproj View 1 2 3 3 chunks +0 lines, -24 lines 0 comments Download
M net/build/net_unittests.vcproj View 1 2 3 2 chunks +0 lines, -8 lines 0 comments Download
D net/http/cert_status_cache.h View 1 2 3 1 chunk +0 lines, -50 lines 0 comments Download
D net/http/cert_status_cache.cc View 1 2 3 1 chunk +0 lines, -65 lines 0 comments Download
M net/http/http_network_layer.h View 1 2 3 1 chunk +0 lines, -9 lines 0 comments Download
M net/http/http_network_layer.cc View 1 2 3 1 chunk +0 lines, -19 lines 0 comments Download
D net/http/http_transaction_winhttp.h View 1 2 3 1 chunk +0 lines, -199 lines 0 comments Download
D net/http/http_transaction_winhttp.cc View 1 2 3 1 chunk +0 lines, -1827 lines 0 comments Download
D net/http/http_transaction_winhttp_unittest.cc View 1 2 3 1 chunk +0 lines, -55 lines 0 comments Download
D net/http/winhttp_request_throttle.h View 1 2 3 1 chunk +0 lines, -104 lines 0 comments Download
D net/http/winhttp_request_throttle.cc View 1 2 3 1 chunk +0 lines, -176 lines 0 comments Download
D net/http/winhttp_request_throttle_unittest.cc View 1 2 3 1 chunk +0 lines, -112 lines 0 comments Download
M net/net.xcodeproj/project.pbxproj View 1 2 3 4 chunks +0 lines, -6 lines 0 comments Download
M net/net_lib.scons View 1 2 3 4 chunks +0 lines, -8 lines 0 comments Download
M net/net_unittests.scons View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M net/proxy/proxy_service.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/layout_tests/run_webkit_tests.py View 1 2 3 2 chunks +0 lines, -6 lines 0 comments Download
M webkit/tools/test_shell/test_shell_switches.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_switches.cc View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M webkit/tools/test_shell/test_shell_win.cc View 1 2 3 12 chunks +16 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
wtc
11 years, 11 months ago (2009-01-13 01:47:37 UTC) #1
eroman
LGTM!
11 years, 11 months ago (2009-01-13 02:02:23 UTC) #2
darin (slow to review)
11 years, 11 months ago (2009-01-13 05:28:42 UTC) #3 
so much agony wrapped up in those few files...  good riddance ;-)

Powered by Google App Engine
This is Rietveld 408576698