Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1763493003: Check that the names buffer is not empty before passing to GetNameFromTT. (Closed)

Created:
4 years, 9 months ago by forshaw
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Check that the names buffer is not empty before passing to GetNameFromTT. Due to implicit conversion if the names buffer is empty then nullptr will be passed to GetNameFromTT which blindly dereferences it leading to a NPD if an invalid font file is read. BUG=583037 Patch by forshaw@ R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/73733f079c086562d8e7c2943ed16cf6f95b2c42

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M core/src/fxge/ge/fx_ge_fontmap.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
forshaw
PTAL.
4 years, 9 months ago (2016-03-03 00:25:23 UTC) #2
Tom Sepez
lgtm
4 years, 9 months ago (2016-03-03 00:26:17 UTC) #3
Tom Sepez
4 years, 9 months ago (2016-03-03 01:38:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
73733f079c086562d8e7c2943ed16cf6f95b2c42 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698