Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 1763493002: Rename png_ functions conflicting with chrome. (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename png_ functions conflicting with chrome. Part of the work required to ship XFA with chrome. BUG=pdfium:396 R=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d87b20e1ae765cb65281c5bd7c12fc41e8a86780

Patch Set 1 #

Patch Set 2 : Fix pngprefix.h comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -13 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M pdfium.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M samples/BUILD.gn View 1 chunk +3 lines, -4 lines 0 comments Download
M samples/samples.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M testing/libfuzzer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M testing/libfuzzer/fuzzers.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/BUILD.gn View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/libpng16/README.pdfium View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/libpng16/pngprefix.h View 1 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/third_party.gyp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Dan, quick review. Thanks.
4 years, 9 months ago (2016-03-02 22:54:21 UTC) #2
dsinclair
lgtm
4 years, 9 months ago (2016-03-02 23:56:41 UTC) #3
Tom Sepez
4 years, 9 months ago (2016-03-03 00:55:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d87b20e1ae765cb65281c5bd7c12fc41e8a86780 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698