Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1763373002: Support multiple categories per message. (Closed)

Created:
4 years, 9 months ago by floitsch
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, Johnni Winther, Siggi Cherem (dart-lang)
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support multiple categories per message. Also move more messages to use this feature. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/65b4256b9e1a98919e0210a4e169a8286bc84603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -109 lines) Patch
M pkg/analyzer/lib/src/generated/error.dart View 3 chunks +4 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/generated/generated/shared_messages.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M pkg/dart_messages/bin/publish.dart View 2 chunks +32 lines, -15 lines 0 comments Download
M pkg/dart_messages/lib/generated/shared_messages.json View 19 chunks +121 lines, -18 lines 0 comments Download
M pkg/dart_messages/lib/shared_messages.dart View 23 chunks +120 lines, -60 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
floitsch
4 years, 9 months ago (2016-03-07 09:34:43 UTC) #2
Brian Wilkerson
LGTM
4 years, 9 months ago (2016-03-07 14:52:08 UTC) #3
floitsch
4 years, 9 months ago (2016-03-07 15:38:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
65b4256b9e1a98919e0210a4e169a8286bc84603 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698